Closed Bug 1068160 Opened 10 years ago Closed 10 years ago

[AccessFu] Present something when the user reaches the end/start of a page.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file, 2 obsolete files)

We will need to have some kind of feedback for the user when there are no more elements to navigate to.
Attachment #8490215 - Attachment is obsolete: true
Attachment #8490215 - Flags: review?(yzenevich)
Attachment #8490220 - Flags: review?(yzenevich)
Blocks: 1069628
Comment on attachment 8490220 [details] [diff] [review]
Send no-move b2g presentation when user reaches start/end of document.

Review of attachment 8490220 [details] [diff] [review]:
-----------------------------------------------------------------

All dependencies landed, would you rebase this patch? Also a couple of comments.

::: accessible/jsat/ContentControl.jsm
@@ +127,4 @@
>        // We failed to move, and the message is not from a child, so forward
>        // to parent.
>        this.sendToParent(aMessage);
> +    } else {

This will happen if we failed to move and the message is from a child (e.g. this._childMessageSenders.has(aMessage.target)).

::: accessible/jsat/Presentation.jsm
@@ +117,5 @@
>    announce: function announce(aAnnouncement) {}, // jshint ignore:line
>  
>  
> +  /**
> +   * User tried to move cursor forward or backward with no success.

Nit: @param

@@ +544,5 @@
> +  function B2GPresenter_noMove(aMoveMethod) {
> +    return {
> +      type: this.type,
> +      details: {
> +        eventType: 'no-move',

Maybe 'vc-no-change' to be in line with other names?
Attachment #8490220 - Flags: review?(yzenevich)
Rebased and fixed feedback.
Attachment #8490220 - Attachment is obsolete: true
Attachment #8495324 - Flags: review?(yzenevich)
Comment on attachment 8495324 [details] [diff] [review]
Send no-move b2g presentation when user reaches start/end of document.

Review of attachment 8495324 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thanks!
Attachment #8495324 - Flags: review?(yzenevich) → review+
https://hg.mozilla.org/mozilla-central/rev/88398ee0998e
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.