Open Bug 1068195 Opened 5 years ago Updated 5 years ago

Fix an invalid MOZ_ASSERT in moz2d code, asserting the value of a constant string pointer

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

People

(Reporter: ehsan, Assigned: mattwoodrow)

Details

(Whiteboard: [leave open])

Attachments

(2 files)

No description provided.
Assignee: nobody → ehsan.akhgari
Blocks: winclang
Attachment #8490259 - Flags: review?(jmuizelaar)
Attachment #8490259 - Flags: review?(jmuizelaar) → review+
Guess something's broken, because the fixed assertion was getting hit. Backed out for Windows crashtest permafail.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dad11e6dcdd

https://tbpl.mozilla.org/php/getParsedLog.php?id=48327924&tree=Mozilla-Inbound
Matt, you added this assertion in bug 1062723, and we are hitting it on our test machines.  What should I do?
Flags: needinfo?(matt.woodrow)
What is the value of samplingRect.Size()?
Flags: needinfo?(matt.woodrow)
I don't know, the only thing I know is the log in comment 2.  Can you please investigate?
Assignee: ehsan.akhgari → matt.woodrow
ping?
Flags: needinfo?(matt.woodrow)
This makes mingw compilation impossible. Since it seems that proper fix will take a while, how about commenting the code for now? The assertion is useless in current form anyway.
Attachment #8524652 - Flags: review?(jmuizelaar)
Comment on attachment 8524652 [details] [diff] [review]
comment the assertion

Review of attachment 8524652 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.
Attachment #8524652 - Flags: review?(jmuizelaar) → review+
Flags: needinfo?(matt.woodrow)
btw, `MOZ_ASSERT_UNREACHABLE("reason")` is shorthand for `MOZ_ASSERT(false, "reason")`.

This bug can be found by clang's optional -Wstring-conversion warning. There are a few other instances of -Wstring-conversion warnings in mozilla-central. :)
No longer blocks: winclang
You need to log in before you can comment on or make changes to this bug.