Closed
Bug 1068195
Opened 10 years ago
Closed 2 years ago
Fix an invalid MOZ_ASSERT in moz2d code, asserting the value of a constant string pointer
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
People
(Reporter: ehsan.akhgari, Unassigned)
Details
(Whiteboard: [leave open])
Attachments
(2 files)
1004 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
Reporter | ||
Updated•10 years ago
|
Attachment #8490259 -
Flags: review?(jmuizelaar)
Updated•10 years ago
|
Attachment #8490259 -
Flags: review?(jmuizelaar) → review+
Comment 2•10 years ago
|
||
Guess something's broken, because the fixed assertion was getting hit. Backed out for Windows crashtest permafail. https://hg.mozilla.org/integration/mozilla-inbound/rev/3dad11e6dcdd https://tbpl.mozilla.org/php/getParsedLog.php?id=48327924&tree=Mozilla-Inbound
Reporter | ||
Comment 3•10 years ago
|
||
Matt, you added this assertion in bug 1062723, and we are hitting it on our test machines. What should I do?
Flags: needinfo?(matt.woodrow)
Reporter | ||
Comment 5•10 years ago
|
||
I don't know, the only thing I know is the log in comment 2. Can you please investigate?
Assignee: ehsan.akhgari → matt.woodrow
Comment 7•10 years ago
|
||
This makes mingw compilation impossible. Since it seems that proper fix will take a while, how about commenting the code for now? The assertion is useless in current form anyway.
Attachment #8524652 -
Flags: review?(jmuizelaar)
Comment 8•10 years ago
|
||
Comment on attachment 8524652 [details] [diff] [review] comment the assertion Review of attachment 8524652 [details] [diff] [review]: ----------------------------------------------------------------- Sure.
Attachment #8524652 -
Flags: review?(jmuizelaar) → review+
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2582b6cec7b0
Whiteboard: [leave open]
Updated•9 years ago
|
Flags: needinfo?(matt.woodrow)
Comment 11•9 years ago
|
||
btw, `MOZ_ASSERT_UNREACHABLE("reason")` is shorthand for `MOZ_ASSERT(false, "reason")`. This bug can be found by clang's optional -Wstring-conversion warning. There are a few other instances of -Wstring-conversion warnings in mozilla-central. :)
Comment 12•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: matt.woodrow → nobody
Updated•2 years ago
|
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•