106824 - mozicon16.xpm missing -> mozilla (gtk build) crashes on startup

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[James Henstridge]

If the mozicon16.xpm file is not found in the icons subdirectory, mozilla will
crash when it tries to dereference a NULL GdkPixmap pointer.  Fix is fairly
simple, and patch to follow.

Comment 1

[James Henstridge]

Attachment: add extra checks when setting the window's icon to prevent crashes.

Comment 2

[David Hyatt]

--> default owner

Comment 3

[John Morrison]

Hmm. Seems reasonable for robustness (although I don't know how common it is 
that that icon would go "missing"). Should we check this in? (Sorry that this
just lay here so long).

Comment 4

[James Henstridge]

I ran into this problem when I was working on Komodo.  I changed the filename it
would use for the icons, but forgot to put the new icons in the right place.

The code for setting the main icon would spit out a few warnings when the file
was missing, but the mini-icon code happily dereference the NULL pointers.  It
isn't a very important bug, but it would be nice to handle this error condition
better.

Comment 5

[Jesse Ruderman]

This code has changed a lot since 2002.  I think the problem is gone.

http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#1803