Closed Bug 1068273 Opened 5 years ago Closed 5 years ago

Clean up web audio editor tests "toggle" documents

Categories

(DevTools Graveyard :: Web Audio Editor, defect)

x86
macOS
defect
Not set

Tracking

(firefox35 wontfix, firefox36 fixed)

RESOLVED FIXED
Firefox 36
Tracking Status
firefox35 --- wontfix
firefox36 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

A few docs in the web audio editor tests use setInterval to toggle connections back and forth in state. We should use actor's connect/disconnect methods once implemented rather than wait on these timers.
Depends on: 1068270
Depends on: 1083881
Assignee: nobody → jsantell
Old try didn't have the AudioNodeActor connectParam method, repushing try
 https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f69fb8c41b7b
Attachment #8507533 - Flags: review?(vporof) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c8528e11e30e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 36
Flags: qe-verify-
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.