106832 - seperatorUri is misspelled, separatorUri => SEPARATOR_URI

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[timeless]

spun off from bug 106386 per brendan as this is a real code change.

------- Additional Comments From [e-mail] 2001-10-24 07:57 -------

alecf:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/global/resources/content/nsTreeController.js&rev=1.8&mark=129,48#125
http://lxr.mozilla.org/mozilla/search?string=seperatorUri
your code is broken. hrm, i guess that means we need to make sure that we
weren't padding around it.


------- Additional Comments From David Bradley 2001-10-24 09:09 -------

For the change below. I don't see any matching definition of this value, in the
patch, which leads me to believe something was missed. But a lxr search only
turns up this, so I think something else is wrong here.
 
===================================================================
RCS file: /cvsroot/mozilla/xpfe/global/resources/content/nsTreeController.js,v
retrieving revision 1.8
diff -u -0 -r1.8 nsTreeController.js
--- xpfe/global/resources/content/nsTreeController.js	2001/09/28 20:14:05	1.8
+++ xpfe/global/resources/content/nsTreeController.js	2001/10/24 14:44:31
@@ -129 +129 @@
-            if (type == seperatorUri)
+            if (type == separatorUri)

------- Additional Comments From james l. 2001-10-24 10:09 -------

The first use of separatorUri doesn't show up in the patch because it uses the
correct spelling:

http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/nsTreeController.js#48



------- Additional Comments From [e-mail] 2001-10-24 10:56 -------

re dbradley's concern yes, it took me a bit, but you'll note that my bonsai url
included the other spelling.

------- Additional Comments From David Bradley 2001-10-24 12:51 -------

Ok, good, then this actually fixes a bug as well as clean up this mispelling.

------- Additional Comments From David Bradley 2001-10-24 12:52 -------

(From update of attachment 54865 [details] [diff] [review])
r=dbradley

I built with the patch under Linux and Win32. No problems.

so this is just the fragment inlined here, it has r=dbradley and can be seen in
the other attachment, seeking sr=brendan.

Comment 1

[Brendan Eich [:brendan]]

sr=[e-mail]

alecf, don't we prefer JAVA_STYLE_CONST_NAMES in JS, so SEPARATOR_URI?  There
are other examples in nsTreeController.js, fixable another day.

/be

Comment 2

[Alec Flett]

yup, that would be preferable, especially given that it's just a const string 

Comment 3

[timeless]

fixed

Comment 4

[sairuh (rarely reading bugmail)]

vrfy fixed by checking lxr.