Closed Bug 1068355 Opened 5 years ago Closed 5 years ago

OdinMonkey: tidy up calls and some names

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(2 files)

These are two small cleanup patches from another patch I abandoned.
Attached patch tidy-namesSplinter Review
Random name/comment tweaks.
Attachment #8490421 - Flags: review?(benj)
The AsmJSCall codegen is a bit weird; we have some platform-specific code in the platform-independent CodeGenerator.cpp; we have some in platform-specific postAsmJSCall.  This patch factors out the platform-independent core into CodeGeneratorShared::emitAsmJSCall and then has the different platforms do what they want before and after.
Attachment #8490422 - Flags: review?(dtc-moz)
Attachment #8490421 - Flags: review?(benj) → review+
Comment on attachment 8490422 [details] [diff] [review]
no-post-asmjs-call

Review of attachment 8490422 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8490422 - Flags: review?(dtc-moz) → review+
https://hg.mozilla.org/mozilla-central/rev/66454be46c6c
https://hg.mozilla.org/mozilla-central/rev/12dc08f29521
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.