Closed
Bug 1068372
Opened 11 years ago
Closed 11 years ago
Web Audio Editor should not be a valid tool in Browser Toolbox
Categories
(DevTools Graveyard :: Web Audio Editor, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: jsantell, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.16 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
This should've been fixed previously, but this should not be an option in the browser toolbox
|
Assignee | |
Comment 1•11 years ago
|
||
Pretty straight forward
https://tbpl.mozilla.org/?tree=Try&rev=ad15beb3fa58
|
||
Updated•11 years ago
|
Attachment #8490441 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 2•11 years ago
|
||
Hi Jordan, the patch didn't apply cleanly:
patching file browser/devtools/main.js
Hunk #1 FAILED at 252
1 out of 1 hunks FAILED -- saving rejects to file browser/devtools/main.js.rej
could you take a look, maybe it needs a rebase against a current tree. Thanks!
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
ah looks like bug 1066218 conflicted, rebased and attached
Attachment #8490441 -
Attachment is obsolete: true
Attachment #8493951 -
Flags: review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•7 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•