Fix -Wunused-const-variable warnings in widget/cocoa

RESOLVED FIXED in Firefox 35

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

(Blocks: 1 bug)

unspecified
mozilla35
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox32 unaffected, firefox33 affected, firefox34 wontfix, firefox35 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8490470 [details] [diff] [review]
cocoa-warnings.patch

Bug 899334 removed the reference to kIconBytes:

widget/cocoa/nsMenuItemIconX.mm:54:23 [-Wunused-const-variable] unused variable 'kIconBytes'

And the following constants are no longer necessary because they are only used to define (removed) kIconBytes:

kIconBitsPerComponent
kIconComponents
kIconBitsPerPixel
kIconBytesPerRow
kIconBytes
Attachment #8490470 - Flags: review?(mstange)
(Assignee)

Comment 1

4 years ago
I forgot to mention that this patch also removes some trailing whitespace in the same source file (nsMenuItemIconX.mm).
Attachment #8490470 - Flags: review?(mstange) → review+
(Assignee)

Comment 2

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d53de50d5a6
status-firefox34: affected → wontfix
status-firefox35: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/3d53de50d5a6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.