MP4/h264 playback is broken in 10.7

RESOLVED FIXED in Firefox 34

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

Trunk
mozilla35
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox32 unaffected, firefox33 unaffected, firefox34+ fixed, firefox35 fixed, firefox-esr31 ?)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The AppleVTLinker assumes the VideoToolbox framework is located in /System/Library/Frameworks

However, in 10.7, the VideoToolbox framework is located in /System/Library/PrivateFrameworks as this framework is only officially available in 10.8
(Assignee)

Comment 1

3 years ago
Make it depend on 1062654, as I'm not going to rebase those patches for a nth time !
Depends on: 1062654
(Assignee)

Comment 2

3 years ago
Created attachment 8490609 [details] [diff] [review]
Enable VideoToolbox framework in 10.7

Enable VideoToolbox framework in 10.7
Attachment #8490609 - Flags: review?(giles)
Comment on attachment 8490609 [details] [diff] [review]
Enable VideoToolbox framework in 10.7

Review of attachment 8490609 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!
Attachment #8490609 - Flags: review?(giles) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e39589387cc3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
(Assignee)

Comment 7

3 years ago
Comment on attachment 8490609 [details] [diff] [review]
Enable VideoToolbox framework in 10.7

Approval Request Comment
[Feature/regressing bug #]: 8490609
[User impact if declined]: mp4 video playback isn't possible in 10.7 without it
[Describe test coverage new/current, TBPL]: Currently tested and passing all tests in 10.8
[Risks and why]: little, it really is just fixing an oversight.
[String/UUID change made/needed]:
Attachment #8490609 - Flags: approval-mozilla-aurora?
(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Approval Request Comment
> [Feature/regressing bug #]: 8490609
We're not yet in the 8 million range for bug numbers. ;) Can you please provide the correct bug number so that we can determine when this issue was introduced?
status-firefox32: --- → ?
status-firefox33: --- → ?
status-firefox34: --- → affected
status-firefox35: --- → fixed
status-firefox-esr31: --- → ?
tracking-firefox34: --- → +
Flags: needinfo?(jyavenard)
The original feature was bug 941296. That's as reasonable a referent as any.
Flags: needinfo?(jyavenard)
status-firefox32: ? → unaffected
status-firefox33: ? → unaffected
(Assignee)

Comment 10

3 years ago
It turns out that the VT code in current Aurora won't work on 10.7. For VT to work in 10.7 (and 10.6) it requires 1059066 (re-based version).

The core reason for VT not to work is that the VT decoder wasn't provided the format type to output.
Does comment 10 mean that there is no point taking this change on Aurora unless we also take bug 1059066? If so, is there a good reason to push for this in 34 or can we take this in 35?
Flags: needinfo?(jyavenard)
I was surprised by comment 10 as well, and would like to hear details. I do think it's reasonable to wait for 35 for this change. Older Macs are more likely to have flash which most sites still use as a fallback.
(In reply to Lawrence Mandel [:lmandel] from comment #11)
> Does comment 10 mean that there is no point taking this change on Aurora
> unless we also take bug 1059066? If so, is there a good reason to push for
> this in 34 or can we take this in 35?

The reason for uplifting this into 34 is that it gives us across the board support on Mac OSX rather than having 10.6 and 10.7 unsupported and only 10.8 supported. AAC on Mac OSX is specifically important to the games initiative.
Is bug 1059066 required as well?
Flags: needinfo?(ajones)
I believe we can do this without the patch from bug 1059066. I've asked jya to produce a minimal, combined, aurora-specific patch, and we'll request for approval on that.
Flags: needinfo?(jyavenard)
Flags: needinfo?(ajones)
Attachment #8490609 - Flags: approval-mozilla-aurora?
Backport of this with other required changes in is bug 1070703. Please follow-up there for Aurora (Firefox 34) support.
status-firefox34: affected → fixed
You need to log in before you can comment on or make changes to this bug.