1068525 - [Text selection] Keep the size of AccessibleCarets during zooming

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P3)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: 2014-06-06-13-09-01.png

+++ This bug was initially created as a clone of Bug #1021527 +++

The size of touch caret and selection carets will be enlarged after zooming-in, which make it look blurry.

The correct behavior is to keep the size still and does not enlarge or shrink when zooming in or zooming out.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Multiple zoom factor to caret size.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Multiply zoom factor by caret size.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Ignore zoom level for AccessibleCaret. (v1)

We want AccessibleCaret be of the same size regardless of the zoom
level. We simply divide the caret's width, height, margin-left, and the
text selection bar's margin-left by current zoom level.

The margin-left of the caret is adjusted from -23px to -23.5px for better
looking.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8605720 [details] [diff] [review]
Ignore zoom level for AccessibleCaret. (v1)

Review of attachment 8605720 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, but what actually calls SetCaretElementPosition during/after a zoom?

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5250c8418ba

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fe06e0f0e6b

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Re roc comment 6:
> This looks fine, but what actually calls SetCaretElementPosition 
> during/after a zoom?

If no selection change or scroll events happens, the last resort for updating carets would be the reflow callback. We'll only update carets when they are visually visible.

The call sequence would be AccessibleCaretEventHub::Reflow() -> AccessibleCaretManager::OnReflow() -> AccessibleCaretManager::UpdateCarets() -> ... -> AccessibleCaret::SetCaretElementPosition()

BTW, I would like to to rename SetCaretElementPosition to SetCaretElementStyle since it now does more than setting the position.

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Ignore zoom level for AccessibleCaret. f=mtseng, r=roc (v2, carry r+)

Rename SetCaretElementPosition -> SetCaretElementStyle.
Rename SetSelectionBarElementPosition -> SetSelectionBarElementStyle.

Comment 11

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/346c13c3d8af

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/346c13c3d8af

Comment 13

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This fix is for AccesibleCaret, not for TouchCaret and SelectionCarets. Thus we will still see the caret size changed when zooming in/out until we enable "layout.accessiblecaret.enabled" on master.