If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the backbone router from the panel

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8490698 [details] [diff] [review]
Remove the backbone router from the Loop panel.

NiKo`: I assume this is wanted, based on comments and patches elsewhere.

This was a simple 15 min removal as the only route we use is the "home" route, hence we just replace it by directly loading the view.

We can't remove the *Router code entirely yet, as its still used by the conversation window.
Attachment #8490698 - Flags: review?(nperriault)
Comment on attachment 8490698 [details] [diff] [review]
Remove the backbone router from the Loop panel.

Review of attachment 8490698 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: browser/components/loop/content/js/panel.jsx
@@ +535,5 @@
>      });
> +    var notifications = new sharedModels.NotificationCollection()
> +
> +    React.renderComponent(<PanelView
> +      client={client} notifications={notifications}

Nit: Each dep on their own line please :)

::: browser/components/loop/test/desktop-local/panel_test.js
@@ +94,4 @@
>      });
>    });
>  
> +

Nit: unneeded whitespace.
Attachment #8490698 - Flags: review?(nperriault) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/b66d501c3289
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/b66d501c3289
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [loop-uplift]
Untracking for QE verification. Please needinfo me to request manual testing.
Flags: qe-verify-
Comment on attachment 8490698 [details] [diff] [review]
Remove the backbone router from the Loop panel.

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8490698 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/d4400ded3075

Updated

3 years ago
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Comment on attachment 8490698 [details] [diff] [review]
Remove the backbone router from the Loop panel.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8490698 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.