Status

defect
RESOLVED WONTFIX
5 years ago
4 years ago

People

(Reporter: gerard-majax, Assigned: gerard-majax)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(2 attachments)

Investigating bug 1043813, I noticed we are lacking a lot of firmwares in /system/etc/firmware/

I'm wondering how much this may impact bug 1043813.
Assignee

Comment 1

5 years ago
Viral, can you help us identifying what are the risks of missing all those firmware?
Flags: needinfo?(vwang)
Whiteboard: [systemsfe]
I think this bug 1043813 is fixed now.
For the risk of missing firmwares, i'm not sure if we should extract all of them from device.

Hi Michael, any suggestion about the /system/etc/firmware/ like we should put all of them to extract-files.sh?
Flags: needinfo?(vwang) → needinfo?(mwu)

Comment 3

5 years ago
It would help to know what files are missing, specifically. Some of the firmware in there is actually provided by CAF repos so we wouldn't want to copy in those cases.
Flags: needinfo?(mwu)
Assignee

Comment 4

5 years ago
Flags: needinfo?(mwu)
Assignee

Comment 6

5 years ago
Michael, this is the result in both JB and KK of comparing the list of files in /system/etc/firmware/. I hope it helps.

Comment 7

5 years ago
Comment on attachment 8497554 [details] [diff] [review]
KK firmwares.diff

Review of attachment 8497554 [details] [diff] [review]:
-----------------------------------------------------------------

::: firmware-t2m.txt
@@ -6,5 @@
>  /system/etc/firmware/a330_pfp.fw
>  /system/etc/firmware/a330_pm4.fw
> -/system/etc/firmware/cpp_firmware_v1_1_1.fw
> -/system/etc/firmware/cpp_firmware_v1_1_6.fw
> -/system/etc/firmware/cpp_firmware_v1_2_0.fw

This looks like some firmware for a camera. We don't appear to be using this type of camera.

@@ -12,5 @@
>  /system/etc/firmware/leia_pm4_470.fw
> -/system/etc/firmware/nfc_test.bin
> -/system/etc/firmware/Signedrompatch_v20.bin
> -/system/etc/firmware/Signedrompatch_v21.bin
> -/system/etc/firmware/Signedrompatch_v24.bin

This looks like blobs for NFC. We probably need it, though we should check if we don't already have copies of this in the NFC repos.

@@ -17,3 @@
>  /system/etc/firmware/wlan/prima/WCNSS_cfg.dat
> -/system/etc/firmware/wlan/prima/WCNSS_qcom_cfg.ini
> -/system/etc/firmware/wlan/prima/WCNSS_qcom_wlan_nv.bin

These are symlinks. They're generated in my build.

Updated

5 years ago
Flags: needinfo?(mwu)
Assignee

Comment 8

5 years ago
(In reply to Michael Wu [:mwu] from comment #7)

[...]

> @@ -12,5 @@
> >  /system/etc/firmware/leia_pm4_470.fw
> > -/system/etc/firmware/nfc_test.bin
> > -/system/etc/firmware/Signedrompatch_v20.bin
> > -/system/etc/firmware/Signedrompatch_v21.bin
> > -/system/etc/firmware/Signedrompatch_v24.bin
> 
> This looks like blobs for NFC. We probably need it, though we should check
> if we don't already have copies of this in the NFC repos.

Thanks! After double checking, I could not find any in repos.

Viral or Vance, can you check with T2M ?
Flags: needinfo?(vwang)
Flags: needinfo?(vchen)
Hi Wesly,

Could you please help to check it with partner first?

I can check it with our NFC RD later since he's PTO now.
Flags: needinfo?(vwang) → needinfo?(wehuang)
Sure, let me check with T2M after they are back from Golden week. Just double confirm, we want to get those 4 files mentioned in comment#8 like I paste below, is my understanding correct?

> > -/system/etc/firmware/nfc_test.bin
> > -/system/etc/firmware/Signedrompatch_v20.bin
> > -/system/etc/firmware/Signedrompatch_v21.bin
> > -/system/etc/firmware/Signedrompatch_v24.bin
Flags: needinfo?(wehuang) → needinfo?(vwang)
Yes!
(In reply to Wesly Huang from comment #10)
> Sure, let me check with T2M after they are back from Golden week. Just
> double confirm, we want to get those 4 files mentioned in comment#8 like I
> paste below, is my understanding correct?
> 
> > > -/system/etc/firmware/nfc_test.bin
> > > -/system/etc/firmware/Signedrompatch_v20.bin
> > > -/system/etc/firmware/Signedrompatch_v21.bin
> > > -/system/etc/firmware/Signedrompatch_v24.bin
Flags: needinfo?(vwang)
Thanks Viral, will follow this with T2M by my tracking list. also ni T2M youlong.

@Youlong: could you put those files mentioned in comment 11 in place so e are able to reach them? Thank you.
Flags: needinfo?(youlong.jiang)
Hi Youlong, after consult RD we can further divide this questions into 2 things:

1. We can find those 4 files (comment#11) in your release (still find them in v184), but not in your nfc repo., so would like to understand if these files are necessary.

2. We want to align the content in "your release" and "nfc repo", so either
 2a. to remove them from your coming release (if they are not needed), or 
 2b. also put them in nfc repo. (if they are needed).

Please help check and confirm. Thank you.
Flags: needinfo?(vchen)

Comment 14

5 years ago
(In reply to Wesly Huang from comment #13)
> Hi Youlong, after consult RD we can further divide this questions into 2
> things:
> 
> 1. We can find those 4 files (comment#11) in your release (still find them
> in v184), but not in your nfc repo., so would like to understand if these
> files are necessary.
> 
> 2. We want to align the content in "your release" and "nfc repo", so either
>  2a. to remove them from your coming release (if they are not needed), or 
>  2b. also put them in nfc repo. (if they are needed).
> 
> Please help check and confirm. Thank you.

hi all -

we've checked our code tree,

> > > -/system/etc/firmware/nfc_test.bin
> > > -/system/etc/firmware/Signedrompatch_v20.bin
> > > -/system/etc/firmware/Signedrompatch_v21.bin
> > > -/system/etc/firmware/Signedrompatch_v24.bin

these components are qcom private modules, we have no permission to release this part to you directly. pls adb pull from our release image version.

tks.
Flags: needinfo?(youlong.jiang)
(In reply to youlong.jiang from comment #14)
> > > > -/system/etc/firmware/nfc_test.bin
> > > > -/system/etc/firmware/Signedrompatch_v20.bin
> > > > -/system/etc/firmware/Signedrompatch_v21.bin
> > > > -/system/etc/firmware/Signedrompatch_v24.bin
> 
> these components are qcom private modules, we have no permission to release
> this part to you directly. pls adb pull from our release image version.

I can pull it in our side.
But I'm not sure what are those files used for. I think all 4 files are nfc relative functions.
Could you please give us more information like when will we need those files?
Thanks!
Flags: needinfo?(youlong.jiang)
Assignee

Comment 16

4 years ago
Nothing happened and will happen.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(youlong.jiang)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.