Closed Bug 1068590 Opened 8 years ago Closed 8 years ago

fx-team build on windows xp fails with recipe for target 'gfxWindowsPlatform.obj' failed

Categories

(Core :: Graphics, defect)

x86
Windows XP
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: anaran, Assigned: longsonr)

References

Details

Attachments

(3 files)

Build fails.
I have run 
./mach clobber
followed by
./mach build
in gecko-dev dir of up-to-date git clone on fx-team

I attach the final part of the log file, which is also available in request (460kB).

Any workaround available?
The end of the log you attached doesn't contain the actual build error. Can you look for and paste here the actual build error?

Realistically though, I don't expect building on Windows XP to work any more. We still support it as a runtime platform, but not as a build arch.
Flags: needinfo?(adrian)
What happens if you run mozmake in the <objdir>/gfx/thebes directory (after you've done the steps in comment 0) is any error message produced.
If this only just broke, it might be a result of bug 1066043, and require an #include adjustment. But I'd want to see the actual error that occurs while compiling gfxWindowsPlatform.cpp (which will be somewhere prior to the eventual failure message shown in attachment 8490716 [details]) to confirm this.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> The end of the log you attached doesn't contain the actual build error. Can
> you look for and paste here the actual build error?

ah, I just cut off a few lines too late.

I include verbatim here just a bit before and up to the location the attachment starts at.

16:12.02 misc_apps_task.c
16:12.02 Warning: C4005 in c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla-config.h: 'WINVER' : macro redefinition
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\firefox-static\media\webrtc\signaling\signaling_sipcc\../../../../dist/include/mozilla-config.h(133) : warning C4005: 'WINVER' : macro redefinition
16:12.02         command-line arguments :  see previous definition of 'WINVER'
16:12.02 Warning: C4005 in c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla-config.h: '_WIN32_WINNT' : macro redefinition
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\firefox-static\media\webrtc\signaling\signaling_sipcc\../../../../dist/include/mozilla-config.h(142) : warning C4005: '_WIN32_WINNT' : macro redefinition
16:12.02         command-line arguments :  see previous definition of '_WIN32_WINNT'
16:12.02 Warning: C4273 in c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h: '_stricmp' : inconsistent dll linkage
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(39) : warning C4273: '_stricmp' : inconsistent dll linkage
16:12.02         c:\Programme\Microsoft Visual Studio 10.0\VC\Include\string.h(142) : see previous definition of '_stricmp'
16:12.02 Warning: C4273 in c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h: '_strnicmp' : inconsistent dll linkage
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(55) : warning C4273: '_strnicmp' : inconsistent dll linkage
16:12.02         c:\Programme\Microsoft Visual Studio 10.0\VC\Include\string.h(182) : see previous definition of '_strnicmp'
16:12.03 publish_int.obj
16:12.47 gfxWindowsPlatform.cpp
16:12.47 c:/tmp/git.mozilla.org/gecko-dev/gfx/thebes/gfxWindowsPlatform.cpp(446) : error C2039: 'SupportsD2D1' : is not a member of 'mozilla::gfx::Factory'
16:12.47         c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla/gfx/2D.h(1078) : see declaration of 'mozilla::gfx::Factory'
16:12.47 c:/tmp/git.mozilla.org/gecko-dev/gfx/thebes/gfxWindowsPlatform.cpp(446) : error C3861: 'SupportsD2D1': identifier not found
16:12.49 

> 
> Realistically though, I don't expect building on Windows XP to work any
> more. We still support it as a runtime platform, but not as a build arch.
Flags: needinfo?(adrian)
This is the answer to comment 2.
I appreciate all the attention!
Aha - see bug 1046550. The SupportsD2D1() method is #ifdef'd, so gfxWindowsPlatform.cpp needs to be more careful about trying to use it.
Blocks: 1046550
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch d2d.txtSplinter Review
Does this work for you?
Attachment #8490730 - Flags: feedback?(adrian)
Comment on attachment 8490730 [details] [diff] [review]
d2d.txt

Review of attachment 8490730 [details] [diff] [review]:
-----------------------------------------------------------------

Build is still in progress, but has built gfx/thebes just fine.
It's currently building media/mtransport.

Thanks!
Flags: in-testsuite-
Attachment #8490730 - Flags: review?(bas)
Assignee: nobody → longsonr
Patch of Bug 1053652 Comment 15 is also still needed.
I am continuing with that one applied now.
Attachment #8490730 - Flags: review?(bas) → review+
Comment on attachment 8490730 [details] [diff] [review]
d2d.txt

With this and Bug 1053652 Comment 15 I got my fx-team firefox built on Windows XP.

Thank you!
Attachment #8490730 - Flags: feedback?(adrian) → feedback+
https://hg.mozilla.org/mozilla-central/rev/29ba45e163d8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.