1068590 - fx-team build on windows xp fails with recipe for target 'gfxWindowsPlatform.obj' failed

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Adrian Aichner [:anaran]]

Attachment: _mach_build-20140917T120513+0000-end-of.txt

Build fails.
I have run 
./mach clobber
followed by
./mach build
in gecko-dev dir of up-to-date git clone on fx-team

I attach the final part of the log file, which is also available in request (460kB).

Any workaround available?

Comment 1

[Benjamin Smedberg]

The end of the log you attached doesn't contain the actual build error. Can you look for and paste here the actual build error?

Realistically though, I don't expect building on Windows XP to work any more. We still support it as a runtime platform, but not as a build arch.

Comment 2

[Robert Longson [:longsonr]]

What happens if you run mozmake in the <objdir>/gfx/thebes directory (after you've done the steps in comment 0) is any error message produced.

Comment 3

[Jonathan Kew [:jfkthame]]

If this only just broke, it might be a result of bug 1066043, and require an #include adjustment. But I'd want to see the actual error that occurs while compiling gfxWindowsPlatform.cpp (which will be somewhere prior to the eventual failure message shown in attachment 8490716 [details]) to confirm this.

Comment 4

[Adrian Aichner [:anaran]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> The end of the log you attached doesn't contain the actual build error. Can
> you look for and paste here the actual build error?

ah, I just cut off a few lines too late.

I include verbatim here just a bit before and up to the location the attachment starts at.

16:12.02 misc_apps_task.c
16:12.02 Warning: C4005 in c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla-config.h: 'WINVER' : macro redefinition
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\firefox-static\media\webrtc\signaling\signaling_sipcc\../../../../dist/include/mozilla-config.h(133) : warning C4005: 'WINVER' : macro redefinition
16:12.02         command-line arguments :  see previous definition of 'WINVER'
16:12.02 Warning: C4005 in c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla-config.h: '_WIN32_WINNT' : macro redefinition
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\firefox-static\media\webrtc\signaling\signaling_sipcc\../../../../dist/include/mozilla-config.h(142) : warning C4005: '_WIN32_WINNT' : macro redefinition
16:12.02         command-line arguments :  see previous definition of '_WIN32_WINNT'
16:12.02 Warning: C4273 in c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h: '_stricmp' : inconsistent dll linkage
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(39) : warning C4273: '_stricmp' : inconsistent dll linkage
16:12.02         c:\Programme\Microsoft Visual Studio 10.0\VC\Include\string.h(142) : see previous definition of '_stricmp'
16:12.02 Warning: C4273 in c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h: '_strnicmp' : inconsistent dll linkage
16:12.02 c:\tmp\git.mozilla.org\gecko-dev\media\webrtc\signaling\src\sipcc\cpr\include\cpr_strings.h(55) : warning C4273: '_strnicmp' : inconsistent dll linkage
16:12.02         c:\Programme\Microsoft Visual Studio 10.0\VC\Include\string.h(182) : see previous definition of '_strnicmp'
16:12.03 publish_int.obj
16:12.47 gfxWindowsPlatform.cpp
16:12.47 c:/tmp/git.mozilla.org/gecko-dev/gfx/thebes/gfxWindowsPlatform.cpp(446) : error C2039: 'SupportsD2D1' : is not a member of 'mozilla::gfx::Factory'
16:12.47         c:\tmp\git.mozilla.org\gecko-dev\firefox-static\dist\include\mozilla/gfx/2D.h(1078) : see declaration of 'mozilla::gfx::Factory'
16:12.47 c:/tmp/git.mozilla.org/gecko-dev/gfx/thebes/gfxWindowsPlatform.cpp(446) : error C3861: 'SupportsD2D1': identifier not found
16:12.49 

> 
> Realistically though, I don't expect building on Windows XP to work any
> more. We still support it as a runtime platform, but not as a build arch.

Comment 5

[Adrian Aichner [:anaran]]

Attachment: mozmake-20140917T125417+0000.txt

This is the answer to comment 2.
I appreciate all the attention!

Comment 6

[Jonathan Kew [:jfkthame]]

Aha - see bug 1046550. The SupportsD2D1() method is #ifdef'd, so gfxWindowsPlatform.cpp needs to be more careful about trying to use it.

Comment 7

[Robert Longson [:longsonr]]

Attachment: d2d.txt

Does this work for you?

Comment 8

[Adrian Aichner [:anaran]]

Comment on attachment 8490730 [details] [diff] [review]
d2d.txt

Review of attachment 8490730 [details] [diff] [review]:
-----------------------------------------------------------------

Build is still in progress, but has built gfx/thebes just fine.
It's currently building media/mtransport.

Thanks!

Comment 9

[Adrian Aichner [:anaran]]

Patch of Bug 1053652 Comment 15 is also still needed.
I am continuing with that one applied now.

Comment 10

[Adrian Aichner [:anaran]]

Comment on attachment 8490730 [details] [diff] [review]
d2d.txt

With this and Bug 1053652 Comment 15 I got my fx-team firefox built on Windows XP.

Thank you!

Comment 11

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=55be333a674c

Comment 12

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29ba45e163d8

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29ba45e163d8