An error message is displayed in "Reviews" page after refresh for apps that contain Cyrillic or Diacritics characters in their name

VERIFIED FIXED

Status

defect
P3
normal
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: julian.mozbugs, Unassigned)

Tracking

x86_64
Windows 7
Dependency tree / graph

Details

(Whiteboard: [ktlo])

Reporter

Description

5 years ago
Steps to reproduce:
1. Sign in to MP-dev.
2. Load the details page of an app that contains Cyrillic or diacritics characters in its name
App with reviews: https://marketplace-dev.allizom.org/app/cantemos-a-jehov%C3%A1-sn?src=search
App without reviews: https://marketplace-dev.allizom.org/app/kanji-text%E9%B9%BF%E9%B9%BF%E7%86%8A%E5%B2%A1%E9%B9%BF%E6%A2%A8%E9%98%9C%E5%9F%BC%E9%B9%BF?src=feed
3. Hit F5 or Refresh the page

Expected results: 
The app details page is loaded correctly. (buttons: Reviews and/or Write a Review are under “Description” or “Version” paragraph)

Actual result:
All review buttons are missing. Tab page title displays “Oh, no!| Firefox Marketplace”

Notes/Issues:
Verified on FF35 (Win 7). Reproducing also on MP-stage and MP-prod.
Screencast for this issue http://screencast.com/t/5YtMGFDmI

Comment 1

5 years ago
We might be getting a 500 there, do you get one in your web console?
Priority: -- → P3
Target Milestone: 2014-09-23 → ---
Reporter

Comment 2

5 years ago
There's a 404 error in the XHR window http://screencast.com/t/2RGczhmhG3PB

Updated

4 years ago
Summary: Buttons regarding reviews are no longer displayed if an app details page is refreshed → "Reviews" section is no longer displayed if an app details page is refreshed for app that contains Cyrillic or Diacritics characters in its name

Comment 3

4 years ago
The issue from comment #0 is reproducing on MP-dev FF39(Win 7) after Desktop UI refresh, following the STR from below:
Steps to reproduce:
1. Load MP-dev page https://marketplace-dev.allizom.org 
2. Load the details page of an app that contains Cyrillic or diacritics characters in its name (i.e. https://marketplace-dev.allizom.org/app/%C8%9B%C8%9B%C8%9B%C8%9B%C4%83%C4%83%C4%83%C4%83%C4%83turtle8259?src=new)
3. Observe the "Reviews" section
4. Refresh the page

Expected results: 
The app details page has no display or layout issues.

Actual result:
The review section is missing.

Notes/Issues:
If the refresh is made in "Reviews" page (i.e. https://marketplace-dev.allizom.org/app/%C5%A3ar%C4%83-buffalo9520/ratings) the message "Oh no!An error occurred." is displayed - http://screencast.com/t/GUicPcrbl0 

Screencast for initial issue: http://screencast.com/t/Iwxg4HTD
Blocks: 1135257
No longer blocks: 1135257
Blocks: 1135257
Whiteboard: [ktlo]
https://github.com/mozilla/fireplace/commit/ec52e30bb4ad66264a91f8c386490429d7776ee7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment 5

4 years ago
The issue from comment #3 is partially fixed; what was mentioned at section "Notes/Issues" from comment #3 is still reproducing: after a refresh in Reviews page an error message is displayed.
Please see the screencast: http://screencast.com/t/suR2Sm18H
Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

4 years ago
The issue from Reviews page, mentioned at comment #5 is reproducing in MP-production FF41(Win 7).
Please see the screencast: http://screencast.com/t/qFb1LFrz8lAI

Updated

4 years ago
Summary: "Reviews" section is no longer displayed if an app details page is refreshed for app that contains Cyrillic or Diacritics characters in its name → An error message is displayed in "Reviews" page after refresh for apps that contain Cyrillic or Diacritics characters in their name
https://github.com/mozilla/fireplace/commit/38f031c900de04d525190094c6c94a6cc2f9f89c
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED

Comment 8

4 years ago
Verified as fixed on MP-dev FF42(Win 7)
Postfix screencast: http://screencast.com/t/PoIwRI8yZdpM
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.