Closed Bug 1068676 Opened 5 years ago Closed 5 years ago

mach test skips devtools browser chrome subsuite

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(1 file, 1 obsolete file)

The |mach test| command seems to ignore the devtools subsuite of browser chrome tests.

For example, |mach test browser/devtools/webconsole| finds no tests, but |mach mochitest-devtools browser/devtools/webconsole| does.
Apparently we didn't teach |mach test| about subsuites.
we did the quick hack since these jobs are fully separated on tbpl.  

I am not sure the best route to add subsuite into mach. In a simple form, we should run everything that is in the given input path (i.e. browser/devtools/webconsole), but that in and of itself could have subsuites.  

Should we ignore subsuite if we have an input path?
Attached file MozReview Request: bz://1068676/jryans (obsolete) —
/r/3457 - Bug 1068676 - Make mach test understand subsuites. r=jmaher

Pull down this commit:

hg pull review -r d3b5c22b23f5d6c42c3c00498180c00de2b9b223
Attachment #8560563 - Flags: review?(jmaher)
Are there tests I should run on try?  I wasn't sure.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8560563 [details]
MozReview Request: bz://1068676/jryans

I am not an expert in mach stuff, this looks good overall!
Attachment #8560563 - Flags: review?(jmaher) → review+
Duplicate of this bug: 1098259
https://hg.mozilla.org/mozilla-central/rev/de4682147093
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla38
Attachment #8560563 - Attachment is obsolete: true
Attachment #8618373 - Flags: review+
Component: Mochitest Chrome → Mochitest
You need to log in before you can comment on or make changes to this bug.