1068693 - Fix the folder button in the header

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Marco Zehe (:MarcoZ)]

menu button in header is actually folders

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

The following things should happen:
* Menu link should be changed from role link to role toggle button
* aria-haspopup attribute should be added
* Menu label should be changed to Folders label.

Comment 2

[aggarwalsahil1992]

please tell some more details about the bug i would like to work on it...

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Sahil,

So if you have open an Email app and log in to an email account (gmail or something like that), you will see a button that looks like 3 horizontal bars (top left). If you enable a screen reader (when running Gaia in Firefox Nightly (https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/Running_the_Gaia_codebase)) in the last tab in the developer tools, you will be able to focus on that button by pressing and holding a button over it.

You will notice that the screen reader output will say 'Menu link' (or similar), we need it to output 'Folder has popup button'. That requires the 3 change mentioned in Comment 1. 

Let me know if you want to take it and ill assign it to you.

Comment 4

[aggarwalsahil1992]

yes sir, I would like to take it...

Comment 5

[aggarwalsahil1992]

Sir,
I have cloned gaia codebase but i am not able to run firefox nighty with it. Whenever i run

/etc/firefox-trunk -profile /path/to/B2G/gaia/profile-debug -no-remote

it simply opens firefox without loading gaia profile. Please guide me how to solve this ?

Thank you

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Sahil, right now Gaia on desktop is broken (see bug 1070830). I am hoping it will get fixed shortly. In the meanwhile you can try writing tests for the changes you were intending, then you'd only need Gaia on desktop to verify that they do what you expect.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Sahil,

Here are instructions of how to run/debug/develop with Gaia code base using B2G Desktop instead of Firefox Desktop: http://yzen.github.io/firefoxos/2014/10/24/today-i-learned.html

Comment 8

[ankitladhania]

Hi,
I would like to fix this bug. But this is my first bug. So i would require lot of mentor-ship.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi, I'm afraid this bug will be fixed along with bug 1068695, would you be interested in this one instead: bug 1072092.

In terms of mentor-ship please see this resources: http://yzen.github.io/firefoxos/2014/11/28/resources-for-contributing.html and let me know if something's missing or you need more help.

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

See Comment 9.

Comment 11

[tusharsircar95]

Sir,
I want to work on this bug. Can you please brief me on it?

Thanks

Comment 12

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to tusharsircar95 from comment #11)
> Sir,
> I want to work on this bug. Can you please brief me on it?
> 
> Thanks

Hi, definitely, take a look at the comments above, they give a good explanation of the problem at hand. Do you think they make sense? Also you can find me in #accessibility IRC channel for questions etc.

Comment 13

[gladys]

I want to work on this bug

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi gladys, sure, I'll assign this to you. Please see comments above and let me know if they make sense?

Thanks!

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

Hi Gladys, perhaps you had some questions about the but? Please, feel free to ask anything or let me know if you need some pointers.

Comment 16

[Yura Zenevich [:yzen] (please use "needinfo")]

Fixed with bug 1072092