1068699 - Each e-mail item should have a sensible reading order for the screen reader

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Marco Zehe (:MarcoZ)]

email option should have this order:

sender -> subject -> date -> body

Separated by commas so the speech pauses slightly between them and doesn't lump them together.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8556588 [details] [review]
Github pull request.

Left some comments in the pull request, flip review back when ready. I can answer questions in the pull request on the review comments.

In general, if there is a way to reduce this work, maybe structure the HTML different to avoid the need to do this, I am open to considering those options.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8556588 [details] [review]
Github pull request.

I think this should be in good shape now.

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8556588 [details] [review]
Github pull request.

This is looking great! Seems better than needing a bunch of l10n variant strings.

I observed fps and overpaint numbers, and I could not see a difference between master and this, so I think performance-wise this approach should be fine. I do see some checkerboarding, but see it in master too, and suspect just master instability/tuning as we have some other painting glitches currently (I filed a separate bug about that previously).

I just had one change around the sendState mentioned in the pull request. Once that is addressed, then this should be good to go.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8556588 [details] [review]
Github pull request.

Took care of the comment, thanks!

Comment 6

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/27790

The pull request could not be applied to the integration branch. Please try again after current integration is complete.

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/47cda5850572ed93088106e86a69fcd3d0c5c31f

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8556588 [details] [review]
Github pull request.

[Approval Request Comment] This pull request fixes the order of email information in the list of emails.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: If declined, the order of information about an email within a list will remain confusing for the screen reader user.
[Testing completed]: manual, unit tests
[Risk to taking this patch] (and alternatives if risky): fairly low, some CSS changes that were tested manually.
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/27790/files#diff-ae23daa44c8175428395919c6fa562b8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/00ac85cf5d42b3d6600d93e552ff659071398468

Comment 10

[Stefan Plewako [:stef]]

> +# LOCALIZATION NOTE(message-header-state-error): For message list card, used to
> +# describe an error state of the message item. The following string is spoken
> +# by screen readers and not shown on the screen.
> +message-header-state-error.ariaLabel=Error sending

This is about message that was not send or sending an error?

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Stefan Plewako [:stef] from comment #10)
> > +# LOCALIZATION NOTE(message-header-state-error): For message list card, used to
> > +# describe an error state of the message item. The following string is spoken
> > +# by screen readers and not shown on the screen.
> > +message-header-state-error.ariaLabel=Error sending
> 
> This is about message that was not send or sending an error?

AFAIK, this is when the message failed to send. Is that right, James?

Comment 12

[James Burke [:jrburke]]

Right, if the outbox folder is shown, and message in that outbox was waiting to be sent had an error on send, then this indicates the sending failed.