Closed Bug 1068700 Opened 10 years ago Closed 9 years ago

Fix bottom toolbar accessibility

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S5 (6feb)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: MarcoZ, Assigned: yzen)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

Github pull request.
46 bytes, text/x-github-pull-request
jrburke
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
Refresh and other buttons are unlabelled. Last sync should be 1 item.
Assignee: nobody → eitan
Assignee: eitan → yzenevich
Attached file Github pull request. — 

        Attachment #8556488 -
        Flags: review?(jrburke)

    
    

    
  
Comment on attachment 8556488 [details] [review]
Github pull request.

Looks good, just want to see consolidation of the refreshBtn changes into a function that can be called in multiple places. Flip review back when that is done, should be easy to r+ after that.

        Attachment #8556488 -
        Flags: review?(jrburke)

    
    

    
  
Comment on attachment 8556488 [details] [review]
Github pull request.

Updated to comments, thanks!

        Attachment #8556488 -
        Flags: review?(jrburke)

        Attachment #8556488 -
        Flags: review?(jrburke) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/e326cae79e977a340864048d86b56ac480971cc9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8556488 [details] [review]
Github pull request.

[Approval Request Comment] This pull request fixes accessibility of the email bottom toolbar.
[Bug caused by] (feature/regressing bug #): improvement not a bug
[User impact] if declined: Screen reader users won't be able to use the bottom toolbar in Email.
[Testing completed]: added unit tests, tested on device
[Risk to taking this patch] (and alternatives if risky): not very risky, fixing a11y related attributes within the toolbar.
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/27782/files#diff-2

        Attachment #8556488 -
        Flags: approval-gaia-v2.2?

        Attachment #8556488 -
        Flags: approval-gaia-v2.2? → approval-gaia-v2.2+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: