Closed Bug 1068705 Opened 10 years ago Closed 9 years ago

in select mode bottom toolbar controls are not labelled

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S5 (6feb)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: MarcoZ, Assigned: yzen)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1])

Attachments

(1 file)

Github pull request.
46 bytes, text/x-github-pull-request
jrburke
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
Related bug 1068700. This is when the e-mail list is in multi-select mode.
Assignee: nobody → yzenevich
Attached file Github pull request. — 

        Attachment #8556502 -
        Flags: review?(jrburke)

    
    

    
  
Comment on attachment 8556502 [details] [review]
Github pull request.

r+ for the second commit in the pull request (first one tracked in another bug).

        Attachment #8556502 -
        Flags: review?(jrburke) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/833a845ab30ca6f991b59678859ffbc778405786
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8556502 [details] [review]
Github pull request.

[Approval Request Comment] This pull request fixes bottom toolbar in edit mode.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: The screen reader users will not be able to use the toolbar in the email in edit mode
[Testing completed]: manual on device + unit tests
[Risk to taking this patch] (and alternatives if risky): fairly safe, only adding a11y attributes
[String changes made]: https://github.com/mozilla-b2g/gaia/pull/27783/files#diff-2

        Attachment #8556502 -
        Flags: approval-gaia-v2.2?

        Attachment #8556502 -
        Flags: approval-gaia-v2.2? → approval-gaia-v2.2+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: