[email/UI] Fix accessibility of e-mail Settings panel

RESOLVED FIXED

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: MarcoZ, Assigned: yzen)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
jrburke
: review+
zcampbell
: review+
Details | Review
This probably needs similar adjustments as the Settings app.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Summary: Fix accessibility of e-mail Settings panel → [email/UI] Fix accessibility of e-mail Settings panel
Attachment #8527885 - Flags: review?(jrburke)
Will look at review, but may be a slightly delayed review. Ideally we could land the first pass of the RTL changes in bug 1064617 and then work from there, since some of the introduced styles may need adjustment in that light. But based on expected US Thanksgiving schedule, it may make more sense to land this first and then have me deal with the resulting merge into the bug 1064617 changeset.
I'll have RTL signoff shortly, let's plan to land that first.
Comment on attachment 8527885 [details] [review]
Github pull request.

The main set of RTL changes landed, details in bug 1064617 comment 11. I apologize for causing some extra merge work for you, but can you switch review back to me after this pull request has been rebased on top of that? I will likely start giving feedback on any RTL issues too for any new pull requests.

Notable for this changeset: the items in the items in the settings are usually in flexbox containers. For the checkboxes, while we have copy/pastes of the HTML for the checkboxes, we usually rely on the shared styles for styling them, so if it makes more sense to do the styling work for those items there, that might be better. On the flip side, that touches a bunch of apps, so need to be mindful of the impact of changes there.

In light of the RTL changes, the specifying of the left: and right: styles likely need extra consideration.
Attachment #8527885 - Flags: review?(jrburke)
Comment on attachment 8527885 [details] [review]
Github pull request.

Switching the flag back on. I rebased the PR and, hopefully, ensured that there aren't any RTL issues with my CSS changes. Thanks!
Attachment #8527885 - Flags: review?(jrburke)
Comment on attachment 8527885 [details] [review]
Github pull request.

r=me for the apps/email parts.
Attachment #8527885 - Flags: review?(jrburke) → review+
Comment on attachment 8527885 [details] [review]
Github pull request.

Marking for test parts review.
Attachment #8527885 - Flags: review?(zcampbell)
Comment on attachment 8527885 [details] [review]
Github pull request.

r-, but tiny nit: change online to external = true.

Also, where will this test run? It can only run outside of CI. currently this test won't get run unless you run it locally on desktopb2g or on a device.
Attachment #8527885 - Flags: review?(zcampbell) → review-
Comment on attachment 8527885 [details] [review]
Github pull request.

Made the change you mentioned. Flipping the flag back, thanks!
Attachment #8527885 - Flags: review- → review?(zcampbell)
Comment on attachment 8527885 [details] [review]
Github pull request.

r+
Attachment #8527885 - Flags: review?(zcampbell) → review+
https://github.com/mozilla-b2g/gaia/commit/47111fd2bbe8b0055c8a596959d701391d2a9953
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.