Closed
Bug 1068787
Opened 6 years ago
Closed 6 years ago
Quota usage not decreased when removing unsuccessfully copied files
Categories
(Core :: Storage: IndexedDB, defect)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: janv, Assigned: janv)
Details
Attachments
(1 file, 2 obsolete files)
15.13 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/ActorsParent.cpp#14780 Either remove it and the file will be removed when the FileInfo goes away or add proper quota manager call to decrease quota usage. Also, I think we don't need to call flush in CopyFileData() if there's an error.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #8496850 -
Flags: review?(bent.mozilla)
Assignee | ||
Comment 2•6 years ago
|
||
Forgot to update the thread assertion in QuotaManager::DecreaseUsageForOrigin()
Attachment #8496850 -
Attachment is obsolete: true
Attachment #8496850 -
Flags: review?(bent.mozilla)
Attachment #8505361 -
Flags: review?(bent.mozilla)
Comment on attachment 8505361 [details] [diff] [review] patch Review of attachment 8505361 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/indexedDB/ActorsParent.cpp @@ +14809,5 @@ > // Try to remove the file if the copy failed. > + nsresult rv2; > + int64_t fileSize; > + > + if (mFileManager->Privilege() != Chrome) { This isn't actually right, is it? Installed non-chrome apps won't have quota tracking enabled, right?
Assignee | ||
Comment 4•6 years ago
|
||
Hm, then it's wrong elsewhere too. It seems we need to expose mEnforcingQuota somehow and use that for checking.
Assignee | ||
Comment 5•6 years ago
|
||
Attachment #8505361 -
Attachment is obsolete: true
Attachment #8505361 -
Flags: review?(bent.mozilla)
Attachment #8506007 -
Flags: review?(bent.mozilla)
Comment on attachment 8506007 [details] [diff] [review] patch Review of attachment 8506007 [details] [diff] [review]: ----------------------------------------------------------------- Yay!
Attachment #8506007 -
Flags: review?(bent.mozilla) → review+
Assignee | ||
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef63ad26842
Comment 8•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ef63ad26842
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•