1068787 - Quota usage not decreased when removing unsuccessfully copied files

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Jan Varga [:janv]]

http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/ActorsParent.cpp#14780

Either remove it and the file will be removed when the FileInfo goes away or add proper quota manager call to decrease quota usage.

Also, I think we don't need to call flush in CopyFileData() if there's an error.

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Jan Varga [:janv]]

Attachment: patch

Forgot to update the thread assertion in QuotaManager::DecreaseUsageForOrigin()

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8505361 [details] [diff] [review]
patch

Review of attachment 8505361 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/indexedDB/ActorsParent.cpp
@@ +14809,5 @@
>              // Try to remove the file if the copy failed.
> +            nsresult rv2;
> +            int64_t fileSize;
> +
> +            if (mFileManager->Privilege() != Chrome) {

This isn't actually right, is it? Installed non-chrome apps won't have quota tracking enabled, right?

Comment 4

[Jan Varga [:janv]]

Hm, then it's wrong elsewhere too.
It seems we need to expose mEnforcingQuota somehow and use that for checking.

Comment 5

[Jan Varga [:janv]]

Attachment: patch

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8506007 [details] [diff] [review]
patch

Review of attachment 8506007 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!

Comment 7

[Jan Varga [:janv]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ef63ad26842

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ef63ad26842