Closed Bug 1068857 Opened 9 years ago Closed 9 years ago

Add support for setting jit options via env vars

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: mjrosenb, Assigned: mjrosenb)

Details

Attachments

(1 file)

env-able_options-r0.patch
6.34 KB, patch
nbp
: review+
Details | Diff | Splinter Review 
I've wanted this on and off, and I've heard a couple of people asking for something that provides this functionality on IRC, so here it is.
Attachment #8490951 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8490951 [details] [diff] [review]
env-able_options-r0.patch

Review of attachment 8490951 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/JitOptions.cpp
@@ +44,5 @@
> +        fprintf(stderr, "Warning: I didn't understand %s=\"%s\"", param, str);
> +    }
> +    return dflt;
> +}
> +#define SET_DEFAULT(var, dflt) var = overrideDefault(#var, dflt)

nit:  var = overrideDefault("JIT_OPTIONS_" #var, dflt)
Attachment #8490951 - Flags: review?(nicolas.b.pierron) → review+
landed: ad1b182f0f51 ... pasting is not working today, so my apologies if I mistyped that.
https://hg.mozilla.org/mozilla-central/rev/ad1b182f0f51
https://hg.mozilla.org/mozilla-central/rev/a98f69d91d7b
Assignee: nobody → mrosenberg
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.