Closed Bug 1068913 Opened 5 years ago Closed 5 years ago
.10][regression] Alerts have wrong button color
STR: open the web console and type "alert('foo');" Actual: White button color, not easily readable. Expected: Button has a more readable color. I think it's a regression from bug 1044595.
Thanks for catching this, Sören. Dão: I first considered using ButtonText, but since the background doesn't use system colors, the foreground probably shouldn't either.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #8491029 - Flags: review?(dao)
Comment on attachment 8491029 [details] [diff] [review] patch Why is !important needed here?
Attachment #8491029 - Flags: review?(dao) → review+
Because the selector that it needs to override is button[default="true"]:not(:-moz-window-inactive), which has higher specificity. (I hope this is true because I haven't actually tested it.)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Does this impact 34? If yes, can you please request Aurora uplift approval this week?
Well, nm. I see that this will be fixed in bug 1044595.
The fix for this was included in the roll-up patch landed in bug 1044595.
bugday-20141029 - verified. Button has a more readable color. Firefox 35 Aurora
Thank you Alona!
You need to log in before you can comment on or make changes to this bug.