[10.10][regression] Alerts have wrong button color

VERIFIED FIXED in Firefox 34

Status

()

Firefox
Theme
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Sören Hentzschel, Assigned: mstange)

Tracking

Trunk
Firefox 35
All
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox34 fixed, firefox35 verified)

Details

(Whiteboard: regression)

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8491008 [details]
screenshot

STR:

open the web console and type "alert('foo');"

Actual:

White button color, not easily readable.

Expected:

Button has a more readable color. I think it's a regression from bug 1044595.
(Assignee)

Comment 1

3 years ago
Created attachment 8491029 [details] [diff] [review]
patch

Thanks for catching this, Sören.

Dão: I first considered using ButtonText, but since the background doesn't use system colors, the foreground probably shouldn't either.
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Attachment #8491029 - Flags: review?(dao)
Comment on attachment 8491029 [details] [diff] [review]
patch

Why is !important needed here?
Attachment #8491029 - Flags: review?(dao) → review+
(Assignee)

Comment 3

3 years ago
Because the selector that it needs to override is button[default="true"]:not(:-moz-window-inactive), which has higher specificity. (I hope this is true because I haven't actually tested it.)
(Assignee)

Comment 4

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b16d1f20bd9
https://hg.mozilla.org/mozilla-central/rev/3b16d1f20bd9
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Does this impact 34? If yes, can you please request Aurora uplift approval this week?
status-firefox34: --- → ?
status-firefox35: --- → fixed
tracking-firefox34: --- → +
Flags: needinfo?(mstange)
Well, nm. I see that this will be fixed in bug 1044595.
status-firefox34: ? → ---
tracking-firefox34: + → ---
Flags: needinfo?(mstange)
The fix for this was included in the roll-up patch landed in bug 1044595.
status-firefox34: --- → fixed
QA Whiteboard: [good first verify]

Comment 9

3 years ago
bugday-20141029 - verified. Button has a more readable color.
Firefox 35 Aurora
Thank you Alona!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][bugday-20141029]
status-firefox35: fixed → verified
You need to log in before you can comment on or make changes to this bug.