Remove FileInfo from File

RESOLVED FIXED in Firefox 43

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: janv, Assigned: janv)

Tracking

Trunk
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
Created attachment 8491095 [details] [diff] [review]
patch
(Assignee)

Updated

3 years ago
Attachment #8491095 - Attachment is patch: true
(Assignee)

Updated

3 years ago
Depends on: 771288
(Assignee)

Comment 1

3 years ago
Created attachment 8504159 [details] [diff] [review]
patch v1
Assignee: nobody → Jan.Varga
Attachment #8491095 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8504159 - Flags: review?(amarchesini)
Comment on attachment 8504159 [details] [diff] [review]
patch v1

Review of attachment 8504159 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.

::: content/base/public/nsIDOMFile.idl
@@ -40,5 @@
>  
>    // Get internal id of stored file. Returns -1 if it is not a stored file.
>    // Intended only for testing. It can be called on any thread.
>    [notxpcom] long long getFileId();
>  

change the UUID for this interface
Attachment #8504159 - Flags: review?(amarchesini) → review+
Any reason why this patch is not landed yet?
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 4

3 years ago
Unfortunately, the patch here depends on other stuff that haven't landed yet.
Flags: needinfo?(Jan.Varga)
(Assignee)

Updated

2 years ago
Summary: Remove FileInfo from DOMFile → Remove FileInfo from File
(Assignee)

Comment 5

2 years ago
Created attachment 8656491 [details] [diff] [review]
patch

rebased patch
Attachment #8504159 - Attachment is obsolete: true
Attachment #8656491 - Flags: review+

Comment 6

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a759b2431a
https://hg.mozilla.org/mozilla-central/rev/a6a759b2431a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.