Closed Bug 1068975 Opened 5 years ago Closed 4 years ago

Remove FileInfo from File

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #8491095 - Attachment is patch: true
Depends on: 771288
Attached patch patch v1 (obsolete) — Splinter Review
Assignee: nobody → Jan.Varga
Attachment #8491095 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8504159 - Flags: review?(amarchesini)
Comment on attachment 8504159 [details] [diff] [review]
patch v1

Review of attachment 8504159 [details] [diff] [review]:
-----------------------------------------------------------------

looks good.

::: content/base/public/nsIDOMFile.idl
@@ -40,5 @@
>  
>    // Get internal id of stored file. Returns -1 if it is not a stored file.
>    // Intended only for testing. It can be called on any thread.
>    [notxpcom] long long getFileId();
>  

change the UUID for this interface
Attachment #8504159 - Flags: review?(amarchesini) → review+
Any reason why this patch is not landed yet?
Flags: needinfo?(Jan.Varga)
Unfortunately, the patch here depends on other stuff that haven't landed yet.
Flags: needinfo?(Jan.Varga)
Summary: Remove FileInfo from DOMFile → Remove FileInfo from File
Attached patch patchSplinter Review
rebased patch
Attachment #8504159 - Attachment is obsolete: true
Attachment #8656491 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a6a759b2431a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.