Closed
Bug 1068980
Opened 10 years ago
Closed 9 years ago
Photo view: back button should be first element in view
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S5 (6feb)
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access, Whiteboard: [b2ga11y p=1])
Attachments
(1 file)
54 bytes,
text/plain
|
pdahiya
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details |
Since it is in the upper left corner, it should be the first item spoken.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8553465 -
Flags: review?(pdahiya)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → eitan
Comment 2•9 years ago
|
||
Comment on attachment 8553465 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27617/commits Giving r- as this fix is hiding back button behind frames in full screen view. Please check. Thanks
Attachment #8553465 -
Flags: review?(pdahiya) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8553465 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27617/commits I added a label (oops!) and raised the z-index.
Attachment #8553465 -
Flags: review- → review?(pdahiya)
Comment 4•9 years ago
|
||
Comment on attachment 8553465 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27617/commits Thanks Eitan, it looks good!
Attachment #8553465 -
Flags: review?(pdahiya) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/8238eeacc7030b2cdbf7ab4eba2f36779b702599
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8553465 [details] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27617/commits [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: The back button will illogically appear after the image view for screen reader users. [Testing completed]: Manual. [Risk to taking this patch] (and alternatives if risky): Low. [String changes made]: None.
Attachment #8553465 -
Flags: approval-gaia-v2.2?
Updated•9 years ago
|
Attachment #8553465 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 7•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/5f03ae9e6af7d406849468b0f0f227ca34b0a587
You need to log in
before you can comment on or make changes to this bug.
Description
•