1068999 - Video view: Video seek bar is not accessible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Eitan Isaacson [:eeejay]]

The collection of distinct accessible nodes should be made into one comprehensive accessible widget.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27799

I chose this approach because (at least in the gallery view) one of the dialogs is translucent. Otherwise, doing this in CSS would be preferable (and potentially cleaner).

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8556785 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27799

Wrong bug, pleased ignore!

Comment 3

[GitHub Autolander Bot]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27932

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27932

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8559347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27932

Need to get used to this autolander business..

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8559349 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27932

r+ if you fix the nits noted on github.

Does the screen reader currently send the keyboard events? I seem to recall Punam saying last week that it wasn't working yet. If it is not working, I'd recommend waiting to land this until it can actually be tested.

Comment 7

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/74af2e3c426e753aaa269d0c22232a4f2959c940

Tested locally, and a fix for screen reader breakage is landing in gecko as we speak.

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 8559349 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/27932

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users will not be able to perceive or operate the video player seek bar.
[Testing completed]: Yes. This has been on master for a while.
[Risk to taking this patch] (and alternatives if risky): Little/no risk
[String changes made]: Added screen reader label description for seek bar.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f62f62fd54cb79df6b4e9f1253e09db6ebe2082c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Linter follow-up fix. I have no clue why Master isn't complaining about this, though :(
v2.2: https://github.com/mozilla-b2g/gaia/commit/be86a57c64529b651e67ba4ae87d70acffbc986a

https://treeherder.mozilla.org/logviewer.html#?job_id=45638&repo=mozilla-b2g37_v2_2

Comment 11

[Kevin Grandon :kgrandon]

It looks like we're running jshint 2.6 in master, and 2.5.x in v2.2 currently. It seems that JShint may have relaxed this rule and that's why we're not seeing it on master.

That could certainly complicate uplifts =/ If it's trivial to get jshint 2.6 onto v2.2 we should do so to ease the pain.

Comment 12

[Kevin Grandon :kgrandon]

FYI - I'll track getting jshint updated in 2.2 in bug 1132819.