Closed Bug 1068999 Opened 5 years ago Closed 5 years ago

Video view: Video seek bar is not accessible.


(Firefox OS Graveyard :: Gaia::Gallery, defect)

Gonk (Firefox OS)
Not set


(b2g-v2.2 fixed, b2g-master fixed)

2.2 S6 (20feb)
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed


(Reporter: eeejay, Assigned: eeejay)



(Keywords: access, Whiteboard: [b2ga11y p=1])


(1 file, 2 obsolete files)

The collection of distinct accessible nodes should be made into one comprehensive accessible widget.
I chose this approach because (at least in the gallery view) one of the dialogs is translucent. Otherwise, doing this in CSS would be preferable (and potentially cleaner).
Assignee: nobody → eitan
Attachment #8556785 - Flags: review?(pdahiya)
Comment on attachment 8556785 [details] [review]
Link to Github pull-request:

Wrong bug, pleased ignore!
Attachment #8556785 - Attachment is obsolete: true
Attachment #8556785 - Flags: review?(pdahiya)
Assignee: eitan → nobody
Comment on attachment 8559347 [details] [review]
Link to Github pull-request:

Need to get used to this autolander business..
Attachment #8559347 - Attachment description: [PullReq] eeejay:bug-1068999 to mozilla-b2g:master → Link to Github pull-request:
Attachment #8559347 - Attachment is obsolete: true
Assignee: nobody → eitan
Comment on attachment 8559349 [details] [review]
Link to Github pull-request:

r+ if you fix the nits noted on github.

Does the screen reader currently send the keyboard events? I seem to recall Punam saying last week that it wasn't working yet. If it is not working, I'd recommend waiting to land this until it can actually be tested.
Attachment #8559349 - Flags: review?(dflanagan) → review+

Tested locally, and a fix for screen reader breakage is landing in gecko as we speak.
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8559349 [details] [review]
Link to Github pull-request:

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users will not be able to perceive or operate the video player seek bar.
[Testing completed]: Yes. This has been on master for a while.
[Risk to taking this patch] (and alternatives if risky): Little/no risk
[String changes made]: Added screen reader label description for seek bar.
Attachment #8559349 - Flags: approval-gaia-v2.2?
Attachment #8559349 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Linter follow-up fix. I have no clue why Master isn't complaining about this, though :(
Flags: needinfo?(kgrandon)
It looks like we're running jshint 2.6 in master, and 2.5.x in v2.2 currently. It seems that JShint may have relaxed this rule and that's why we're not seeing it on master.

That could certainly complicate uplifts =/ If it's trivial to get jshint 2.6 onto v2.2 we should do so to ease the pain.
Flags: needinfo?(kgrandon)
FYI - I'll track getting jshint updated in 2.2 in bug 1132819.
You need to log in before you can comment on or make changes to this bug.