Closed Bug 1069017 Opened 6 years ago Closed 2 years ago
.sh should have a target for flashing gecko + gaia
43 bytes, text/x-github-pull-request
|Details | Review|
It would be helpful if flash.sh had a target for flashing gecko and gaia at once. This is useful when updating a tree to current source and reflashing. It's useful to have a single target for two reasons: (1) it saves waiting for the device to reboot and typing another command. (2) there's code that runs at startup to reregister gaia apps when the gecko version or build id changes. If you reflash gecko, reboot, and then flash gaia, this code doesn't get invoked correctly with the new gaia. See http://hg.mozilla.org/mozilla-central/file/4f2cac8d72da/dom/apps/AppsUtils.jsm#l482 and its callers. I don't have a strong opinion about what the command could be called. I was thinking "gecko-and-gaia", although maybe "shallow" makes more sense?
I don't have strong opinions about the name here; this is just an initial suggestion, really.
Attachment #8491148 - Flags: review?(mwu)
Comment on attachment 8491148 [details] [review] link to https://github.com/mozilla-b2g/B2G/pull/387 "shallow" sounds good to me. The actual implementation looks fine. r=me with the name changed to shallow.
Attachment #8491148 - Flags: review?(mwu) → review+
Pull request updated with the new name. (Who can merge it?)
Target Milestone: --- → 2.1 S6 (10oct)
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.