1069017 - flash.sh should have a target for flashing gecko + gaia

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It would be helpful if flash.sh had a target for flashing gecko and gaia at once.

This is useful when updating a tree to current source and reflashing.  It's useful to have a single target for two reasons:

 (1) it saves waiting for the device to reboot and typing another command.

 (2) there's code that runs at startup to reregister gaia apps when the gecko version or build id changes.  If you reflash gecko, reboot, and then flash gaia, this code doesn't get invoked correctly with the new gaia.  See http://hg.mozilla.org/mozilla-central/file/4f2cac8d72da/dom/apps/AppsUtils.jsm#l482 and its callers.


I don't have a strong opinion about what the command could be called.  I was thinking "gecko-and-gaia", although maybe "shallow" makes more sense?

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: link to https://github.com/mozilla-b2g/B2G/pull/387

I don't have strong opinions about the name here; this is just an initial suggestion, really.

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8491148 [details] [review]
link to https://github.com/mozilla-b2g/B2G/pull/387

"shallow" sounds good to me. The actual implementation looks fine. r=me with the name changed to shallow.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Pull request updated with the new name.  (Who can merge it?)

Comment 4

[Michael Wu [:mwu]]

Sheriffs can.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/B2G/commit/f5da5f5d2c4606960196ba3c19f61722ba5ed970

Comment 6

[BMO Automation]

Firefox OS is not being worked on