Closed
Bug 1069176
Opened 10 years ago
Closed 10 years ago
[homescreen] unittest configurator_test.js incorrect using assert.include for testing existing object property
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Firefox OS Graveyard
Gaia::Homescreen
Tracking
(b2g-v2.2 fixed)
RESOLVED
FIXED
2.1 S5 (26sep)
Tracking | Status | |
---|---|---|
b2g-v2.2 | --- | fixed |
People
(Reporter: sv99, Assigned: sv99)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20140917114326
Steps to reproduce:
193: assert.include(document.body.classList, 'searchPageEnabled');
assert.include - test inclusion of an object in another. Works for strings and Arrays, for other do nothing!!
Summary: [homescreen] unittest configurator_test.js incorrect using assert.include for testing existing object propertyng → [homescreen] unittest configurator_test.js incorrect using assert.include for testing existing object property
Attachment #8491321 -
Flags: review?(felash)
Comment 2•10 years ago
|
||
Comment on attachment 8491321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24163
Redirecting to a peer for the homescreen
Attachment #8491321 -
Flags: review?(felash) → review?(crdlc)
Comment 3•10 years ago
|
||
Comment on attachment 8491321 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/24163
LGTM
Attachment #8491321 -
Flags: review?(crdlc) → review+
Updated•10 years ago
|
Assignee: nobody → sv99
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•