1069178 - Drop some old references to serverUrl/baseServerUrl in Loop desktop code

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

The desktop side of Loop removed the need for baseServerUrl/serverUrl when we started routing hawk requests via the Loop API.

There's still a few remnants that we need to clean up.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

This removes the dead code :-)

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

Review of attachment 8491329 [details] [diff] [review]:
-----------------------------------------------------------------

Dead-code removal = always winning :)

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/fx-team/rev/9b4a0e65bfaa

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9b4a0e65bfaa

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

Approval Request Comment
Uplift request for patches staged and tested on Fig

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/74afe98b3b9f

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.