Drop some old references to serverUrl/baseServerUrl in Loop desktop code

RESOLVED FIXED in Firefox 34

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla35
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

Attachments

(1 attachment)

The desktop side of Loop removed the need for baseServerUrl/serverUrl when we started routing hawk requests via the Loop API.

There's still a few remnants that we need to clean up.
Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

Review of attachment 8491329 [details] [diff] [review]:
-----------------------------------------------------------------

Dead-code removal = always winning :)
Attachment #8491329 - Flags: review?(mdeboer) → review+
Flags: qe-verify-
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/9b4a0e65bfaa
Target Milestone: --- → mozilla35
https://hg.mozilla.org/mozilla-central/rev/9b4a0e65bfaa
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

Approval Request Comment
Uplift request for patches staged and tested on Fig
Attachment #8491329 - Flags: approval-mozilla-aurora?
Comment on attachment 8491329 [details] [diff] [review]
Bug 1069178 Drop some old references to serverUrl/baseServerUrl in Loop desktop code.

I worked with Randell and Maire on uplifting a large number of Loop bugs at once. All of the bugs have been staged on Fig and tested by QE before uplift to Aurora. As well, all of the bugs are isolated to the Loop client. Randell handled the uplift with my approval. I am adding approval to the bug after the fact for bookkeeping.
Attachment #8491329 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.