Closed Bug 1069232 Opened 8 years ago Closed 8 years ago

[Wappush] Issue in asychronous unit tests

Categories

(Firefox OS Graveyard :: Gaia::Wappush, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
gsvelto
: review+
Details | Review
I found this issue while working on bug 874510: some tests are asynchronous but don't use "done".
Assignee: nobody → felash
Attached file github PR
I took the liberty to remove all asynchronicity in this file, by using the synchronous API for the mock. Benefits are: no possible intermittent, faster tests. Inconvenients are: the test is less readable :)

Tell me if you'd prefer that I simply add a "done" in the incorrect tests.
Attachment #8491375 - Flags: review?(gsvelto)
Comment on attachment 8491375 [details] [review]
github PR

+1 for synchronous tests if doing them asynchronously doesn't bring anything to the table. I tend to keep tests asynchronous where it makes sense to - for example because it can expose race conditions - but in this case we know the settings API already works so this is faster and better. I've left only a nit on the PR about the debugging code you seem to have left in the mock.
Attachment #8491375 - Flags: review?(gsvelto) → review+
fixed the nit and landed

master: 42ba2edfaef2fb4e5f9810deece74918079ba1e1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.