1069253 - twice 'let text' in inputKeyPress

Status: RESOLVED INVALID

(Thunderbird :: Instant Messaging, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

/mail/components/im/content/imconversation.xml

line 419:
let text = inputBox.value;

line 530 (still same method):
let text = inputBox.value;

This should break due to bug 1001090.

Comment 1

[Patrick Cloke [:clokep]]

Comment on attachment 8491418 [details] [diff] [review]
patch, v1

Review of attachment 8491418 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently Florian asked me over IRC to r- this, but I have no idea why. Bouncing the review.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8491418 [details] [diff] [review]
patch, v1

These two |let text = ...| are in different scopes (and even different functions).