Closed Bug 1069271 Opened 6 years ago Closed 6 years ago

Bookmark Deduplicator 1.2 doesn't work after landing patches from bug #1001090

Categories

(WebExtensions :: General, defect)

35 Branch
x86_64
Windows 7
defect
Not set
major

Tracking

(firefox34 unaffected, firefox35 verified)

VERIFIED FIXED
Tracking Status
firefox34 --- unaffected
firefox35 --- verified

People

(Reporter: Virtual, Assigned: jorgev)

References

()

Details

(Keywords: addon-compat, nightly-community, Whiteboard: [Fixed in Bookmark Deduplicator 1.3.1])

Doesn't work in latest Nightly.
This error is shown in Error Console:

1411041145198	addons.xpi	WARN	Exception running bootstrap method startup on bookmarkdeduplicator@foxhatdev: TypeError: redeclaration of variable rootNode (resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@foxhatdev.xpi!/bootstrap.js -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@foxhatdev.xpi!/lib/deduplicateBookmarks.js:41:8) JS Stack trace: require@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@bootstrap.js:158:2 < @resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@foxhatdev.xpi!/bootstrap.js -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@main.js:13:11 < require@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@bootstrap.js:158:2 < startup@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///C:/Users/Virtual_ManPL/AppData/Roaming/Mozilla/Firefox/Profiles/93fe7q9t.default/extensions/bookmarkdeduplicator@bootstrap.js:42:2 < XPI_callBootstrapMethod@XPIProvider.jsm:4434:9 < XPI_updateAddonDisabledState@XPIProvider.jsm:4557:1 < AddonWrapper_userDisabledSetter@XPIProvider.jsm:6887:9 < set_userDisabled@extensions.xml:1084:11 < oncommand@about:addons:1:1
[Tracking Requested - why for this release]: Regression - please mark this addon as not compatible with Firefox 35 and up, as it not works anymore from these versions due to bug #1001090
Jorge - can you mark this not compatible?
Flags: needinfo?(jorge)
Done. I also downgraded the add-on on the site to reduce its visibility.
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jorge)
Resolution: --- → FIXED
@ Jorge Villalobos [:jorgev] - I'm requesting undo reduction Bookmark Deduplicator visibility, as newest version 1.3.1 works fine even in latest Nightly.
Incompatibility for older Bookmark Deduplicator versions than 1.3.1 can stay.
Flags: needinfo?(jorge)
Whiteboard: [Fixed in Bookmark Deduplicator 1.3.1]
I'll give it a look, thanks.
Flags: needinfo?(jorge)
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
Version: Firefox 35 → 35 Branch
You need to log in before you can comment on or make changes to this bug.