1069363 - "show user list again" link does not include is_enabled for showing previous results list

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[David Lawrence [:dkl]]

When searching for users and then returning to the seearch form in editusers.cgi, the previous value of "Restrict search to 'All|Enabled|Disabled' users" is not passed through properly.

Found this by running test_user_groups.t selenium test.

dkl

Comment 1

[David Lawrence [:dkl]]

Attachment: 1069363_1.patch

Comment 2

[Frédéric Buclin]

Bugzilla 4.4 also has this problem, so I'm a bit surprised that you only see the Selenium script fails on trunk, unless you changed the code.

Comment 3

[:glob ✱]

Comment on attachment 8491528 [details] [diff] [review]
1069363_1.patch

Review of attachment 8491528 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 4

[:glob ✱]

4.4 needs a different patch, because the field name is "enabled_only" there.

Comment 5

[David Lawrence [:dkl]]

Attachment: 1069363_4_4_1.patch

Comment 6

[:glob ✱]

Comment on attachment 8492377 [details] [diff] [review]
1069363_4_4_1.patch

Review of attachment 8492377 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

Comment 7

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   5d96fa7..6b518aa  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   e9f5fda..392fcaf  4.4 -> 4.4

Comment 8

[:glob ✱]

this issue isn't important enough to warrant the blocking flag.

the litmus test is if we should cut a release immediately to deploy this fix; that isn't the case with this issue as it's a relatively minor bug.