106941 - Profile.cpp using nsIPref - not nsIPrefService

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Chip Clark]

This is part of a larger clean up project to move from nsIPref to nsIPrefService
and nsIPrefBranch

Comment 1

[Chip Clark]

Attachment: diff for Profile.cpp (cvs -q diff -uN mozilla/profile)

Comment 2

[Chip Clark]

requesting r= sr=

Comment 3

[Alec Flett]

Comment on attachment 55253 [details] [diff] [review]
diff for Profile.cpp (cvs -q diff -uN mozilla/profile)

look at the logic in nsProfile::LoadDefaultProfileDir()
you'll see that the extra if (NS_FAILED(rv)) is totally unnecessary.
There's a similar issue in ConfirmAutoMigration

Comment 4

[Brian Nesse (gone)]

Yes, in both cases it would probably just be better to do a
if (NS_FAILED(rv)) return(rv);

rather than testing if (NS_SUCCEEDED(rv))

Comment 5

[Chip Clark]

Attachment: Profile.cpp - removing extra(unnecessary) if statements

Comment 6

[Brian Nesse (gone)]

Comment on attachment 55303 [details] [diff] [review]
Profile.cpp - removing extra(unnecessary) if statements

Much cleaner. :) r=bnesse.

Comment 7

[Alec Flett]

Comment on attachment 55303 [details] [diff] [review]
Profile.cpp - removing extra(unnecessary) if statements

agreed. sr=alecf

Comment 8

[Brian Nesse (gone)]

Fix checked in.

Comment 9

[sairuh (rarely reading bugmail)]

rs vrfy by checking lxr.