Closed Bug 1069420 Opened 10 years ago Closed 6 years ago

add a way to filter stylesheets (it's very hard to find a stylesheet in B2G)

Categories

(DevTools :: Style Editor, enhancement, P3)

x86_64
All
enhancement

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: paul, Unassigned)

References

Details

Attachments

(1 file)

Some B2G apps have dozens of stylesheet. And some gaia developers are complaining! Let's fix that.
Attached patch patch.diffSplinter Review
Heather, let me revive the stylesheet filter textbox I deleted 2 years ago.

To keep the code simple, I decided to not hide the items, but fade them. Then I don't have to handle the complicated cases where a selected sheet gets hidden, and when we want to navigate with arrows through non-hidden/hidden sheets. I know it's not optimal, but I believe it's good enough.
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #8492137 - Flags: review?(fayearthur)
Heather, if you think this is too "quick & dirty", I can work on a better approach. I just need some pointer of how to do that properly.
What if now you end up spending more time on looking/scrolling through a large list and finding which all items are non-faded ?
(In reply to Girish Sharma [:Optimizer] from comment #3)
> What if now you end up spending more time on looking/scrolling through a
> large list and finding which all items are non-faded ?

right. I just don't know how to fix that properly.
Review ping?
Flags: needinfo?(fayearthur)
Ping?
Heather, this is very important for our developers. I'd like to fix that asap. Can you please tell me what the best approach is?
Comment on attachment 8492137 [details] [diff] [review]
patch.diff

Review of attachment 8492137 [details] [diff] [review]:
-----------------------------------------------------------------

I think this would help at least a bit.

My only request is that we hide the bar if there are <5 stylesheets.

We can do real filtering in the future. Bug 1014646 would help as well, just making the entries shorter.
Attachment #8492137 - Flags: review?(fayearthur) → review+
Flags: needinfo?(fayearthur)
Assignee: paul → nobody
Status: ASSIGNED → NEW
Inspector bug triage (filter on CLIMBING SHOES).
Severity: normal → enhancement
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P3
Product: Firefox → DevTools
Mass closing as we are no longer working on b2g/firefox os.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
Mass closing as we are no longer working on b2g/firefox os.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: