Padding between syntax box and following h3 too small

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: fscholz, Assigned: shobson)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8491594 [details]
h3-padding-syntaxbox-correct.png

Regression from just a couple of minutes ago – possibly related to CustomCSS.
I am attaching screen shots.
(Reporter)

Comment 1

4 years ago
Created attachment 8491595 [details]
h3-padding-syntaxbox-wrong.png
(Assignee)

Updated

4 years ago
Assignee: nobody → shobson
Severity: normal → minor

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/8e173857a070211aced305d841604b6e947a4b8a
Fix Bug 1069432 - Padding between syntax box and following h3 too small

Integrated styles for syntax from customCSS into the main files.
- Moved styles into individual 'component' files after talking to @darkwing and @openjck.
- Extracted colours into variables (made rgba values into hex to avoid contrast problems on dark background colours)
- Removed competing and redundant rules (do we really need to declare margin-top:0 specifically if there is no margin-top on the element?)

You will need to run compress assets to properly test this!

Some test pages:
https://developer.mozilla.org/en-US/docs/Web/API/Blob.Blob
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise#Syntax
https://developer.mozilla.org/en-US/docs/Web/API/AudioBuffer

https://github.com/mozilla/kuma/commit/ca8fa34b6d4d65936b3098875e5baf4b15596cc9
Merge pull request #2755 from stephaniehobson/BUG-1018707-empty-customcss

Fix Bug 1069432 - Padding between syntax box and following h3 too small

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.