Closed
Bug 1069525
Opened 10 years ago
Closed 10 years ago
(Settings) Network > Data Dialogs are using the wrong styles.
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:-)
RESOLVED
FIXED
| blocking-b2g | - |
People
(Reporter: padamczyk, Assigned: pivanov)
References
Details
(Whiteboard: [Tako_Blocker])
Attachments
(3 files)
|
34.39 KB,
image/png
|
Details | |
|
46 bytes,
text/x-github-pull-request
|
arthurcc
:
review+
padamczyk
:
ui-review+
|
Details | Review |
|
124.60 KB,
application/zip
|
padamczyk
:
ui-review+
|
Details |
Wrong Style Dialog
The fonts in this dialog are really small, most of our dialogs use bigger text.
This affects "Data Connection" and "Data Roaming" dialogs.
|
Assignee | |
Comment 1•10 years ago
|
||
Hey Patryk,
we use 2.2rem font size for paragraphs and 1.6rem for titles. I think if there are bigger fonts in some dialogs they don't use [BB]. Do we need to change something on the current dialogs?
Flags: needinfo?(padamczyk)
|
Reporter | |
Comment 2•10 years ago
|
||
Przemek do we have dialog spec ready, it would be good to get Pavel to work from that.
Flags: needinfo?(padamczyk) → needinfo?(pabratowski)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Ignore comment 2.
Pavel, I think the issue here is that the dialog fonts are too small, they should be bigger.
Ie look at the dialog when you try to access Music and have the phone plugged in via USB. The sizing is way different.
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(pabratowski)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8500992 -
Flags: ui-review?(padamczyk)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Hey Patryk,
here are few shots.
Attachment #8501608 -
Flags: ui-review?(padamczyk)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8500992 -
Flags: ui-review?(padamczyk) → ui-review+
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8501608 [details]
Device Shots
Looks good, ship it!
Attachment #8501608 -
Flags: ui-review?(padamczyk) → ui-review+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8500992 -
Flags: review?(ehung)
|
||
Updated•10 years ago
|
Attachment #8500992 -
Flags: review?(ehung) → review?(arthur.chen)
|
||
Comment 7•10 years ago
|
||
Comment on attachment 8500992 [details] [review]
patch for Gaia/master
r=me, thanks!
Attachment #8500992 -
Flags: review?(arthur.chen) → review+
|
|
Assignee | |
Comment 8•10 years ago
|
||
Thanks :)
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/591c2c5cda69232d88c30e8b5e8a44602bd0a54f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Comment 9•10 years ago
|
||
This is an important message around user cost and thus the sense of security. It must have high readability. Please fix
blocking-b2g: --- → 2.1?
Whiteboard: [Tako_Blocker]
|
||
Comment 10•10 years ago
|
||
Blocking- for not meeting blocker criteria:
https://wiki.mozilla.org/B2G/Triage#Blocker_Triage_Guidelines
However, request approval on the patch to get an uplift to 2.1.
blocking-b2g: 2.1? → -
|
||
Comment 11•10 years ago
|
||
hi Dietrich,
may i know if you have requested approval to land this patch to 2.1?
Flags: needinfo?(dietrich)
|
|
||
Comment 12•10 years ago
|
||
(In reply to Francis Lee [:frlee] from comment #11)
> hi Dietrich,
>
> may i know if you have requested approval to land this patch to 2.1?
Nope. I was recommending that whoever wants it landed should do so.
Flags: needinfo?(dietrich)
You need to log in
before you can comment on or make changes to this bug.
Description
•