Closed Bug 1069569 Opened 8 years ago Closed 8 years ago

Complain about missing tests even when the test manifest is not filtered at build time

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: nalexander, Assigned: nalexander)

Details

Attachments

(1 file, 1 obsolete file)

The sandbox currently doesn't complain if a test file is missing unless the test manifest is filtered at build time.  That applies to all suites but xpcshell tests at this time.

This is like Bug 979640, but for xpcshell tests.  (And any new suites that define manifests but don't filter at build time.)
We had some tests that aren't well formed with the new condition.
Everything else is clear, I think.  Try build forthcoming.
Attachment #8491755 - Flags: review?(mshal)
Since bug 857966 landed, if you filter tests with strict=True (which it looks like emitter.py is), then manifestparser should complain for you. Is that not working?
(In reply to Nick Alexander :nalexander from comment #0)
> unless the test manifest is filtered at build time

Oh sorry, missed that part. Carry on.
Comment on attachment 8491755 [details] [diff] [review]
Complain about missing test files for all suites. r=mshal

Gah, bad bzexport.
Attachment #8491755 - Attachment is obsolete: true
Attachment #8491755 - Flags: review?(mshal)
Attachment #8491847 - Flags: review?(mshal) → review+
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/a5e8a4bff194
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.