Closed
Bug 1069572
Opened 11 years ago
Closed 11 years ago
Add method to Maximise the browser
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: automatedtester, Assigned: automatedtester)
References
Details
Attachments
(1 file, 1 obsolete file)
5.15 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
This currently supported in WebDriver so we should add it too
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8491910 -
Flags: review?(jgriffin)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → dburns
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
Comment on attachment 8491910 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window
Review of attachment 8491910 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/marionette/marionette-server.js
@@ +2457,5 @@
> + return;
> + }
> +
> + let curWindow = this.getCurrentWindow();
> + curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);
Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior of pressing the maximize button?
Attachment #8491910 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Comment on attachment 8491910 [details] [diff] [review]
> Add maximise_window() to Marionette to allow maximising the browser window
>
> Review of attachment 8491910 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: testing/marionette/marionette-server.js
> @@ +2457,5 @@
> > + return;
> > + }
> > +
> > + let curWindow = this.getCurrentWindow();
> > + curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);
>
> Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior
> of pressing the maximize button?
It was working without it (locally) but it isnt going to hurt to add it.
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
Assignee | ||
Comment 8•11 years ago
|
||
Comment on attachment 8492082 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window
adding moveTo as per comment and landed. Carrying r+ forward
Attachment #8492082 -
Flags: review+
Assignee | ||
Updated•11 years ago
|
Attachment #8491910 -
Attachment is obsolete: true
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•