Add method to Maximise the browser

RESOLVED FIXED in mozilla35

Status

Product:
Testing
Component:
Marionette
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
3 years ago

People

(Reporter: automatedtester, Assigned: automatedtester)

Tracking

Version:
unspecified
Target:
mozilla35
Platform:
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Add maximise_window() to Marionette to allow maximising the browser window
5.15 KB, patch
automatedtester
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
4 years ago 
This currently supported in WebDriver so we should add it too
(Assignee)

Comment 3

•
4 years ago 
Created attachment 8491910 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window
Attachment #8491910 - Flags: review?(jgriffin)
 (Assignee)

Updated

•
4 years ago
Assignee: nobody → dburns
Status: NEW → ASSIGNED

Comment 4

•
4 years ago 
Comment on attachment 8491910 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

Review of attachment 8491910 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2457,5 @@
> +      return;
> +    }
> +
> +    let curWindow = this.getCurrentWindow();
> +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);

Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior of pressing the maximize button?
Attachment #8491910 - Flags: review?(jgriffin) → review+
 (Assignee)

Comment 5

•
4 years ago 
(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Comment on attachment 8491910 [details] [diff] [review]
> Add maximise_window() to Marionette to allow maximising the browser window
> 
> Review of attachment 8491910 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/marionette-server.js
> @@ +2457,5 @@
> > +      return;
> > +    }
> > +
> > +    let curWindow = this.getCurrentWindow();
> > +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);
> 
> Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior
> of pressing the maximize button?

It was working without it (locally) but it isnt going to hurt to add it.
 (Assignee)

Comment 7

•
4 years ago 
Created attachment 8492082 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window
 (Assignee)

Comment 8

•
4 years ago 
Comment on attachment 8492082 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

adding moveTo as per comment and landed. Carrying r+ forward
Attachment #8492082 - Flags: review+
 (Assignee)

Updated

•
4 years ago
Attachment #8491910 - Attachment is obsolete: true

Comment 9

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/4d99a011dffe
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Blocks: 1257035
You need to log in before you can comment on or make changes to this bug.