1069572 - Add method to Maximise the browser

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

This currently supported in WebDriver so we should add it too

Comment 1

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=42ae13b2688a

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=d2087744db97

Comment 3

[David Burns :automatedtester]

Attachment: Add maximise_window() to Marionette to allow maximising the browser window

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8491910 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

Review of attachment 8491910 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2457,5 @@
> +      return;
> +    }
> +
> +    let curWindow = this.getCurrentWindow();
> +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);

Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior of pressing the maximize button?

Comment 5

[David Burns :automatedtester]

(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Comment on attachment 8491910 [details] [diff] [review]
> Add maximise_window() to Marionette to allow maximising the browser window
> 
> Review of attachment 8491910 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/marionette-server.js
> @@ +2457,5 @@
> > +      return;
> > +    }
> > +
> > +    let curWindow = this.getCurrentWindow();
> > +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);
> 
> Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior
> of pressing the maximize button?

It was working without it (locally) but it isnt going to hurt to add it.

Comment 6

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d99a011dffe

Comment 7

[David Burns :automatedtester]

Attachment: Add maximise_window() to Marionette to allow maximising the browser window

Comment 8

[David Burns :automatedtester]

Comment on attachment 8492082 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

adding moveTo as per comment and landed. Carrying r+ forward

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d99a011dffe