Closed Bug 1069572 Opened 8 years ago Closed 8 years ago

Add method to Maximise the browser

Categories

(Testing :: Marionette, defect)

Product:
Testing
Component:
Marionette
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: automatedtester, Assigned: automatedtester)

References

Details

Attachments

(1 file, 1 obsolete file)

Add maximise_window() to Marionette to allow maximising the browser window
5.15 KB, patch
automatedtester
: review+
Details | Diff | Splinter Review 
This currently supported in WebDriver so we should add it too
Assignee: nobody → dburns
Status: NEW → ASSIGNED
Comment on attachment 8491910 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

Review of attachment 8491910 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/marionette-server.js
@@ +2457,5 @@
> +      return;
> +    }
> +
> +    let curWindow = this.getCurrentWindow();
> +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);

Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior of pressing the maximize button?
Attachment #8491910 - Flags: review?(jgriffin) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #4)
> Comment on attachment 8491910 [details] [diff] [review]
> Add maximise_window() to Marionette to allow maximising the browser window
> 
> Review of attachment 8491910 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: testing/marionette/marionette-server.js
> @@ +2457,5 @@
> > +      return;
> > +    }
> > +
> > +    let curWindow = this.getCurrentWindow();
> > +    curWindow.resizeTo(curWindow.screen.availWidth, curWindow.screen.availHeight);
> 
> Don't we also need a call to curWindow.moveTo(0,0) to emulate the behavior
> of pressing the maximize button?

It was working without it (locally) but it isnt going to hurt to add it.
Comment on attachment 8492082 [details] [diff] [review]
Add maximise_window() to Marionette to allow maximising the browser window

adding moveTo as per comment and landed. Carrying r+ forward
Attachment #8492082 - Flags: review+
Attachment #8491910 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/4d99a011dffe
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.