1069599 - Usage: Settings screen: sub-headers should be level 2.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now the settings sub-headers in the Usage app are not announced and only text is. It should actually be assigned the right role and level.

Comment 1

[Mitchell Van Der Hoeff]

I was wondering if this would be possible to test on the B2G simulator without a SIM.
Currently, I am unable to open the Usage app without a SIM card.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Mitchell Van Der Hoeff from comment #1)
> I was wondering if this would be possible to test on the B2G simulator
> without a SIM.
> Currently, I am unable to open the Usage app without a SIM card.

I believe that is the problem :(. However, it is possible to write a test for the changes and I could test it on device when reviewing. Would that work? If you are still interested, let me know, and I will assign the bug to you!

Comment 3

[Mitchell Van Der Hoeff]

Alright.

Is there any way I could write this test?
Or is that not necessary and is it easy enough just to change the level of these sub-headers and let someone with a device test it?

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Mitchell Van Der Hoeff from comment #3)
> Alright.
> 
> Is there any way I could write this test?
> Or is that not necessary and is it easy enough just to change the level of
> these sub-headers and let someone with a device test it?

Yes so you'd need to update all subheader tags like this https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/settings.html#L71 with ARIA attributes for headers and appropriate labels.

Actually here you would not need the tests since you are just changing the markup.

Comment 5

[Mitchell Van Der Hoeff]

Okay, thanks. 

One last question: where do I find the Usage app? I cannot find it in the `mozilla-b2g/gaia` repo.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Mitchell Van Der Hoeff from comment #5)
> Okay, thanks. 
> 
> One last question: where do I find the Usage app? I cannot find it in the
> `mozilla-b2g/gaia` repo.

Right :) , it's costcotrol.

Comment 7

[Mitchell Van Der Hoeff]

(In reply to Yura Zenevich [:yzen] from comment #6)
> (In reply to Mitchell Van Der Hoeff from comment #5)
> > Okay, thanks. 
> > 
> > One last question: where do I find the Usage app? I cannot find it in the
> > `mozilla-b2g/gaia` repo.
> 
> Right :) , it's costcotrol.

Oh I see, got it.

Comment 8

[Mitchell Van Der Hoeff]

Attachment: A patch to fix the level of the headers in the Usage app

There were 4 gaia-subheader tags to which I added the attributes 'aria-level="2"' and 'role="heading"'.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8499735 [details] [diff] [review]
A patch to fix the level of the headers in the Usage app

a11y-r+ me, thanks Mitchell.

Could you please create a Github pull request with the changes in the patch so it could then be merged into Gaia master? Once you've done that, please, mark Salvador de la Puente González for the review since I am not a peer for the app.

Thanks again!

Comment 10

[Mitchell Van Der Hoeff]

Comment on attachment 8499735 [details] [diff] [review]
A patch to fix the level of the headers in the Usage app

Pull Request can be found at: https://github.com/mozilla-b2g/gaia/pull/24851

Comment 11

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Mitchell's pull request.

Comment 12

[Salvador de la Puente González [:salva]]

Comment on attachment 8501728 [details] [review]
Mitchell's pull request.

Sorry for the delay. i was working on blockers. Nice work. Thank you.

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Salvador de la Puente González [:salva] from comment #12)
> Comment on attachment 8501728 [details] [review]
> Mitchell's pull request.
> 
> Sorry for the delay. i was working on blockers. Nice work. Thank you.

Mitchell, could you rebase your pull request with latest master to re-trigger the tests. Thanks!

Comment 14

[Mitchell Van Der Hoeff]

(In reply to Yura Zenevich [:yzen] from comment #13)
> (In reply to Salvador de la Puente González [:salva] from comment #12)
> > Comment on attachment 8501728 [details] [review]
> > Mitchell's pull request.
> > 
> > Sorry for the delay. i was working on blockers. Nice work. Thank you.
> 
> Mitchell, could you rebase your pull request with latest master to
> re-trigger the tests. Thanks!
Rebased and pushed to personal fork. Should tests run automatically now?

Comment 15

[Yura Zenevich [:yzen] (please use "needinfo")]

Great, thanks, lets wait till it finishes.

Yes you can see an auto-comment on your pull request from try-server-hook with a link to the test run.

Comment 16

[Sudheesh Singanamalla (:ShellHacker)]

Comment on attachment 8501728 [details] [review]
Mitchell's pull request.

The failures in the Gij test seem unrelated. r+

Comment 17

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/baaff455fd2c42c6319df77e1b77ee49c9e45ca5

Comment 18

[Kevin Grandon :kgrandon]

I've backed this out for having an improper commit message. There was no bug number present in the commit message which makes tracking down history much harder in the future. I've gone ahead and re-landed your original commit with the proper bug number and reviewer.

Backout: https://github.com/mozilla-b2g/gaia/commit/dca789329eb8ae5c24b4c387546478a965fe8821
Re-land: https://github.com/mozilla-b2g/gaia/commit/20a686b2126d3f5765c8bebfb6360dd47b724c4a

I'm very upset that this got 2+ reviews and no one noticed this.

Comment 19

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Kevin Grandon :kgrandon from comment #18)
> I've backed this out for having an improper commit message. There was no bug
> number present in the commit message which makes tracking down history much
> harder in the future. I've gone ahead and re-landed your original commit
> with the proper bug number and reviewer.
> 
> Backout:
> https://github.com/mozilla-b2g/gaia/commit/
> dca789329eb8ae5c24b4c387546478a965fe8821
> Re-land:
> https://github.com/mozilla-b2g/gaia/commit/
> 20a686b2126d3f5765c8bebfb6360dd47b724c4a
> 
> I'm very upset that this got 2+ reviews and no one noticed this.

Urgh, my bad. I should've got it. Mitchell could you please rebase the pull request with the following format: "Bug 1069599 - ... r=salva"

Thanks

Comment 20

[Kevin Grandon :kgrandon]

No worries - it happens. I'm hoping to have a bot done soon that will alert us of this.

This has already been re-landed with the proper commit message in comment 18. Thanks!