Closed Bug 1069601 Opened 10 years ago Closed 9 years ago

Usage: Settings screen: data usage inforamation should be unified by line.

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Milestone:
2.2 S6 (20feb)
Tracking Flags:
Tracking Status
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access, Whiteboard: [b2ga11y p=1][NaBfT])

Attachments

(1 file)

[PullReq] yzen:bug-1069601 to mozilla-b2g:master
46 bytes, text/x-github-pull-request
mai
: review+
bajaj
: approval-gaia-v2.2+
Details | Review 
Right now each text is accessible in itself but we should group things together meaningfully (preferable by line).
Whiteboard: [b2ga11y p=1] → [b2ga11y p=1][NaBfT]
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Comment on attachment 8560691 [details] [review]
[PullReq] yzen:bug-1069601 to mozilla-b2g:master

This will ensure that the list items are treated as a single entity without stepping into its content.
Attachment #8560691 - Flags: review?(salva)
Comment on attachment 8560691 [details] [review]
[PullReq] yzen:bug-1069601 to mozilla-b2g:master

Hi Marina, can you take a look at this bug, please? Thank you!
Attachment #8560691 - Flags: review?(salva) → review?(marina.rodrigueziglesias)
Comment on attachment 8560691 [details] [review]
[PullReq] yzen:bug-1069601 to mozilla-b2g:master

LGTM. Thanks!
Attachment #8560691 - Flags: review?(marina.rodrigueziglesias) → review+
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
https://github.com/mozilla-b2g/gaia/commit/e69e07028d407a4fd23289ded91451688d19a851
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8560691 [details] [review]
[PullReq] yzen:bug-1069601 to mozilla-b2g:master

[Approval Request Comment] This pull request improves accessibility of the Usage app settings.
[Bug caused by] (feature/regressing bug #): improvement, not a bug
[User impact] if declined: If declined, screen readers will end up having an inefficient navigation across Usage settings.
[Testing completed]: On device.
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: None
Attachment #8560691 - Flags: approval-gaia-v2.2?
Attachment #8560691 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: