1069611 - No memory card dialog is not exclusively visible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Right now if the screen reader user opens a music app and gets a 'no sd card' dialog popup, they can still navigate to the screen underneath it, even though the dialog is supposed to hide then. This should be fixed.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] eeejay:bug-1069611 to mozilla-b2g:master

Comment 2

[Eitan Isaacson [:eeejay]]

Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

Passes tests, and ready for review.

Comment 3

[Dominic Kuo [:dkuo]]

Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

Eitan, the code looks good to me, however I have a suggestion on github, please take a look and feel free to adopt it or not.

I am not familiar with the gaia-ui-tests, so setting additional review to Johan, thanks.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

The test looks really simple, the manifest is correctly filled, I don't see any major reason to not merge this test in our code base.

One small minor nit in it though.

Comment 5

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/5693ecba5e54062700b77e3d4e5a0a12f969edcc

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Music interface will be operable via screen reader even when the overlay is blocking it.
[Testing completed]: Yes. We also have a python ui test.
[Risk to taking this patch] (and alternatives if risky): Very low.
[String changes made]: None.

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Eitan Isaacson [:eeejay] from comment #6)
> Comment on attachment 8560168 [details] [review]
> [PullReq] eeejay:bug-1069611 to mozilla-b2g:master
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> [User impact] if declined: Music interface will be operable via screen
> reader even when the overlay is blocking it.
> [Testing completed]: Yes. We also have a python ui test.
> [Risk to taking this patch] (and alternatives if risky): Very low.
> [String changes made]: None.

I am approving this as an exception, but please note we are limiting changes on 2.2 and will no longer be approving non-blockers to help converge and stabilize in the next few weeks.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e346140b7633470d23e768097c07e75694929f0f