No memory card dialog is not exclusively visible.

RESOLVED FIXED in 2.2 S7 (6mar)

Status

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: yzen, Assigned: eeejay)

Tracking

({access})

unspecified
2.2 S7 (6mar)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.2 fixed, b2g-master fixed)

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 attachment)

Reporter

Description

5 years ago
Right now if the screen reader user opens a music app and gets a 'no sd card' dialog popup, they can still navigate to the screen underneath it, even though the dialog is supposed to hide then. This should be fixed.
Assignee: nobody → eitan
Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

Passes tests, and ready for review.
Attachment #8560168 - Flags: review?(dkuo)
Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

Eitan, the code looks good to me, however I have a suggestion on github, please take a look and feel free to adopt it or not.

I am not familiar with the gaia-ui-tests, so setting additional review to Johan, thanks.
Attachment #8560168 - Flags: review?(jlorenzo)
Attachment #8560168 - Flags: review?(dkuo)
Attachment #8560168 - Flags: review+
Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

The test looks really simple, the manifest is correctly filled, I don't see any major reason to not merge this test in our code base.

One small minor nit in it though.
Attachment #8560168 - Flags: review?(jlorenzo) → review+
Comment on attachment 8560168 [details] [review]
[PullReq] eeejay:bug-1069611 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Music interface will be operable via screen reader even when the overlay is blocking it.
[Testing completed]: Yes. We also have a python ui test.
[Risk to taking this patch] (and alternatives if risky): Very low.
[String changes made]: None.
Attachment #8560168 - Flags: approval-gaia-v2.2?
(In reply to Eitan Isaacson [:eeejay] from comment #6)
> Comment on attachment 8560168 [details] [review]
> [PullReq] eeejay:bug-1069611 to mozilla-b2g:master
> 
> [Approval Request Comment]
> [Bug caused by] (feature/regressing bug #):
> [User impact] if declined: Music interface will be operable via screen
> reader even when the overlay is blocking it.
> [Testing completed]: Yes. We also have a python ui test.
> [Risk to taking this patch] (and alternatives if risky): Very low.
> [String changes made]: None.

I am approving this as an exception, but please note we are limiting changes on 2.2 and will no longer be approving non-blockers to help converge and stabilize in the next few weeks.
Attachment #8560168 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.