1069615 - Tab panels are not exclusively visible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

When the screen reader user navigates between the different tabs, they should only have access to the current tab panel and the rest of them should be hidden from the screen reader. At the moment the user can swipe away from the current tab panel into the 'hidden' ones.

Comment 2

[GitHub Autolander Bot]

Attachment: [PullReq] eeejay:bug-1069615 to mozilla-b2g:master

Comment 3

[Jim Porter (:squib)]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

I'm not a good person to look at this; I'm still pretty unfamiliar with the music transitions. Dominic would be a better reviewer when he gets back.

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

Eitan, the patch looks okay but I have found some issues, feel free to request review again after you address them, thanks.

Comment 5

[Eitan Isaacson [:eeejay]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

Pushed version with issues addressed.

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

eeejay, after I re-tested the patch, I found another noticeable issue which will break the basic functionality(open activity), please address it and you probably need to check the styles when music is in open activity again, also I have a question on github for you, thanks.

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

Thanks for noticing that! Fixed. And, I hopefully answered your question.

Comment 8

[Dominic Kuo [:dkuo]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

Looks good to me!

Comment 9

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/61369d5cfd9cb7e29bf8d6098d5e36bdee1892b5

Comment 10

[Eitan Isaacson [:eeejay]]

Comment on attachment 8560146 [details] [review]
[PullReq] eeejay:bug-1069615 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users will be able to "see" tabs they are not currently on, and will get the wrong perception of the state of the music app.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: No.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/2de64a844d444b202eec05a754fa8f97930a91a9