1069617 - Playlist/artist/albums/songs items are not a proper and operable list.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Depending on the tab panel open in the music app, the lists that are displayed there should have proper semantics and well operable. They are not at the moment.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] eeejay:bug-1069617 > mozilla-b2g:master

Comment 2

[Jim Porter (:squib)]

Comment on attachment 8563021 [details] [review]
[gaia] eeejay:bug-1069617 > mozilla-b2g:master

r- for now, but only because I have some questions on GitHub. Dominic might be a better person to look at this anyway, since I think he knows more about this part of the code.

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8563021 [details] [review]
[gaia] eeejay:bug-1069617 > mozilla-b2g:master

Gave some clarifications in the pull request, and flagging Dominic for review.

Comment 4

[Dominic Kuo [:dkuo]]

Comment on attachment 8563021 [details] [review]
[gaia] eeejay:bug-1069617 > mozilla-b2g:master

eeejay, the patch looks good with one minor issue, please see github for detail.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/9d47aa9ce7a23682839c196d12abdff5c3ee81c6

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8563021 [details] [review]
[gaia] eeejay:bug-1069617 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Screen reader users won't be able to operate all the lists in the music app.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: No.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/41cb667cb5762e3f660097ae08f6bb07fd70d449

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest Nightly build of Flame v2.2&master by the STR in Comment 0.

Actual results: Screen reader users are able to operate all the lists, and the Playlist/Artist/Albums/Songs list items have proper semantics.
See attachment: verified_master.3gp
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150702162501
Gaia Revision          2d6cbec3a4004bb770ecbadbba83f86b95365e56
Gaia Date              2015-07-02 13:40:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b465f8d7254f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150702.195016
Firmware Date          Thu Jul  2 19:50:27 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150702160209
Gaia Revision          722028715a56a03f327e2e70f2c32dcb6d819d4c
Gaia Date              2015-07-02 08:51:28
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2f25351c5b05
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150702.193535
Firmware Date          Thu Jul  2 19:35:46 EDT 2015
Bootloader             L1TC000118D0

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_master.3gp

Comment 10

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2.3gp