1069620 - gfxPrefs should deal with callback scenarios

Status: NEW

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Suggested by :seth in https://bugzilla.mozilla.org/show_bug.cgi?id=980036#c3.  Good idea, lets us be consistent.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: One potential approach for Moz2D

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8497592 [details] [diff] [review]
One potential approach for Moz2D

Review of attachment 8497592 [details] [diff] [review]:
-----------------------------------------------------------------

This approach should work and adds no performance overhead, which is also good. I like it!

::: gfx/2d/Logging.h
@@ +55,5 @@
>  }
>  
>  #endif
>  
> +class PreferenceAccess;

Why would you forward declare here? Probably just slipped in by accident :)

@@ +60,5 @@
> +class PreferenceAccess
> +{
> +public:
> +  virtual ~PreferenceAccess();
> +  virtual void LivePref(const char* aName, int32_t* aVar, int32_t aDefault);

Let's document this function so people overloading it understand what we're doing :).

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8497592 [details] [diff] [review]
One potential approach for Moz2D

Review of attachment 8497592 [details] [diff] [review]:
-----------------------------------------------------------------

Seems bugzilla got confused.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Bas Schouten (:bas.schouten) from comment #2)
> ...
> >  
> > +class PreferenceAccess;
> 
> Why would you forward declare here? Probably just slipped in by accident :)

Old habit, since I'm using PreferenceAccess* inside the class.  I'll get rid of it and try changing my habits :)

> 
> ...
> > +  virtual void LivePref(const char* aName, int32_t* aVar, int32_t aDefault);
> 
> Let's document this function so people overloading it understand what we're
> doing :).

Good point, will do.

Thanks!