Closed Bug 1069628 Opened 10 years ago Closed 10 years ago

Introduce sound for end-of-page in screen reader

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(1 file)

If the user tries to swipe passed the start or end of a page, they should hear something to indicate no more items.
Comment on attachment 8504963 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25151

Could you tell me where is the no-move event come from?
Also please add a basic unit test for any js change.
Attachment #8504963 - Flags: review?(alive) → feedback+
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #2)
> Comment on attachment 8504963 [details] [review]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25151
> 
> Could you tell me where is the no-move event come from?

It was introduced in the patch from bug 1068160. It is an 'accessibility-output' mozChromeEvent. It is similar to the other accessibility-output events and is emitted from our chrome-js screen reader.

> Also please add a basic unit test for any js change.

Done, thanks.
Attachment #8504963 - Flags: review?(alive)
Comment on attachment 8504963 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25151

r=me thx!
Attachment #8504963 - Flags: review?(alive) → review+
https://github.com/mozilla-b2g/gaia/pull/25151
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: