Closed Bug 1069716 Opened 9 years ago Closed 9 years ago

Custom counter style renders the wrong symbol, with certain testcase

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: dholbert, Assigned: xidorn)

References

(
URL
)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

testcase
544 bytes, text/html
Details
patch
3.92 KB, patch
heycam
: review+
Details | Diff | Splinter Review 
Filing this as a followup to fix the rendering issue discussed in bug 1066089.

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=8488217
(labeled as "testcase 3" on bug 1066089)

I'll post more details and a public copy of the testcase on this (non-security-sensitive) bug within the next day or so.  (Bug 1066089 is still hidden for the moment, since it's only been fixed in Nightly builds since this morning, I believe.)

Xidorn, I'm optimistically tagging you as the assignee, per bug 1066089 comment 12.
URL: https://bugzilla.mozilla.org/attachme...
Summary: Custom counter style renders the wrong character, with certain testcase → Custom counter style renders the wrong symbol, with certain testcase
The testcases are rendered correctly in the latest Nightly in my machine. It seems that it has been fixed in some other bug?
Just to be clear, here are the results I'm seeing/expecting:

ACTUAL RESULTS: The <li> has a bullet to its left.
EXPECTED RESULTS: The <li> should have "b." to its left.

Latest nightly 35.0a1 (2014-09-18) gives me ACTUAL RESULTS.
Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0


(An older Nightly from 2014-08-08 gives me EXPECTED RESULTS. I'm pretty sure this behavior changed with bug 931668's landing. Adding 'regression' keyword & marking as blocking that bug.)
Keywords: regression
(so, doesn't seem to be fixed here... are you sure you're on the latest nightly? And, what platform are you on? I suppose it's possible that this is a platform-specific thing, though I wouldn't expect it to be.)
Oh, right, it's not fixed. The page I saved from the attachment included the style directly, which made it seemed to be fixed.
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #8492020 -
        Flags: review?(dbaron)

    
    

    
  

      
      
      
      

        Attached file
          
        testcase
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
Fix a mochitest failure. This patch passes all tests in Linux x64 Opt: https://tbpl.mozilla.org/?tree=Try&rev=0ba34e181372

In addition, the testcase is included in this patch.

        Attachment #8492020 -
        Attachment is obsolete: true

        Attachment #8492020 -
        Flags: review?(dbaron)

        Attachment #8492581 -
        Flags: review?(cam)

    
    

    
  
Comment on attachment 8492581 [details] [diff] [review]
patch

Review of attachment 8492581 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

        Attachment #8492581 -
        Flags: review?(cam) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c8510704ccdb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35

          You need to log in
          before you can comment on or make changes to this bug.