1069716 - Custom counter style renders the wrong symbol, with certain testcase

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Filing this as a followup to fix the rendering issue discussed in bug 1066089.

Testcase: https://bugzilla.mozilla.org/attachment.cgi?id=8488217
(labeled as "testcase 3" on bug 1066089)

I'll post more details and a public copy of the testcase on this (non-security-sensitive) bug within the next day or so.  (Bug 1066089 is still hidden for the moment, since it's only been fixed in Nightly builds since this morning, I believe.)

Xidorn, I'm optimistically tagging you as the assignee, per bug 1066089 comment 12.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

The testcases are rendered correctly in the latest Nightly in my machine. It seems that it has been fixed in some other bug?

Comment 2

[Daniel Holbert [:dholbert]]

Just to be clear, here are the results I'm seeing/expecting:

ACTUAL RESULTS: The <li> has a bullet to its left.
EXPECTED RESULTS: The <li> should have "b." to its left.

Latest nightly 35.0a1 (2014-09-18) gives me ACTUAL RESULTS.
Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0


(An older Nightly from 2014-08-08 gives me EXPECTED RESULTS. I'm pretty sure this behavior changed with bug 931668's landing. Adding 'regression' keyword & marking as blocking that bug.)

Comment 3

[Daniel Holbert [:dholbert]]

(so, doesn't seem to be fixed here... are you sure you're on the latest nightly? And, what platform are you on? I suppose it's possible that this is a platform-specific thing, though I wouldn't expect it to be.)

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Oh, right, it's not fixed. The page I saved from the attachment included the style directly, which made it seemed to be fixed.

Comment 5

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: testcase

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch

Fix a mochitest failure. This patch passes all tests in Linux x64 Opt: https://tbpl.mozilla.org/?tree=Try&rev=0ba34e181372

In addition, the testcase is included in this patch.

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8492581 [details] [diff] [review]
patch

Review of attachment 8492581 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8510704ccdb

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8510704ccdb