Closed Bug 1069730 Opened 10 years ago Closed 10 years ago

Unsafe mEssentialTrackBuffers.Clear() in MSR::ReadMetadata

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla35

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

fix
5.70 KB, patch
cajbir
: review+
Details | Diff | Splinter Review
Attached patch fix — — Splinter Review 
The decoder monitor used to protect access to mEssentialTrackBuffers must also be held when clearing it in MediaSourceReader::ReadMetadata().

This is the likely cause of bug 1069326 (and possibly bug 1069327, although that is less clear).

Try run: https://tbpl.mozilla.org/?tree=Try&rev=99126f60dfcb
Attachment #8491973 - Flags: review?(cajbir.bugzilla)
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Blocks: 1065250
OS: Linux → All
Hardware: x86_64 → All
Blocks: 1069326
Blocks: 1069327
Attachment #8491973 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/cafcd5e8dc59
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: