Closed Bug 1069776 Opened 5 years ago Closed 13 days ago

Crash on shutdown when installing extension via -silent

Categories

(Firefox :: New Tab Page, defect)

34 Branch
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: bc, Unassigned)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: crash, regression, testcase)

Attachments

(1 file)

3.54 KB, application/x-xpinstall
Details
Attached file quitter.xpi
Debug only, All platforms.

1. download quitter.xpi (see attachment)
2. unzip -d /tmp/quitter quitter.xpi 
3. firefox -CreateProfile "testprofile /tmp/testprofile"
4. mkdir -p /tmp/testprofile/extensions/quitter@squarefree.com
5. cp /tmp/quitter/* /tmp/testprofile/extensions/quitter@squarefree.com/
6. firefox -P testprofile -silent

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff1b5ca61 in mozilla::storage::Service::Observe (this=<optimized out>, aTopic=<optimized out>)
    at /mozilla/builds/nightly/mozilla/storage/src/mozStorageService.cpp:934
934	          MOZ_CRASH();

#0  0x00007ffff1b5ca61 in mozilla::storage::Service::Observe (this=<optimized out>, aTopic=<optimized out>)
    at /mozilla/builds/nightly/mozilla/storage/src/mozStorageService.cpp:934
#1  0x00007ffff142c6c0 in nsObserverList::NotifyObservers (this=0x7fffd9fe70f8, aSubject=aSubject@entry=0x0, 
    aTopic=aTopic@entry=0x7ffff439c655 "xpcom-shutdown-threads", someData=someData@entry=0x0)
    at /mozilla/builds/nightly/mozilla/xpcom/ds/nsObserverList.cpp:100
#2  0x00007ffff142c812 in nsObserverService::NotifyObservers (this=0x7fffe9a9b140, aSubject=aSubject@entry=0x0, 
    aTopic=aTopic@entry=0x7ffff439c655 "xpcom-shutdown-threads", aSomeData=aSomeData@entry=0x0)
    at /mozilla/builds/nightly/mozilla/xpcom/ds/nsObserverService.cpp:329
#3  0x00007ffff149ba2c in mozilla::ShutdownXPCOM (aServMgr=0x7ffff7d92848) at /mozilla/builds/nightly/mozilla/xpcom/build/nsXPComInit.cpp:846
#4  0x00007ffff149c1d0 in NS_ShutdownXPCOM (aServMgr=<optimized out>) at /mozilla/builds/nightly/mozilla/xpcom/build/nsXPComInit.cpp:779
#5  0x00007ffff3784a1d in ScopedXPCOMStartup::~ScopedXPCOMStartup (this=0x7ffff7dab790, __in_chrg=<optimized out>)
    at /mozilla/builds/nightly/mozilla/toolkit/xre/nsAppRunner.cpp:1273
#6  0x00007ffff378dabb in XREMain::XRE_main (this=this@entry=0x7fffffffc720, argc=argc@entry=4, argv=argv@entry=0x7fffffffdbf8, 
    aAppData=aAppData@entry=0x7fffffffc920) at /mozilla/builds/nightly/mozilla/toolkit/xre/nsAppRunner.cpp:4219
#7  0x00007ffff378dd13 in XRE_main (argc=4, argv=0x7fffffffdbf8, aAppData=0x7fffffffc920, aFlags=<optimized out>)
    at /mozilla/builds/nightly/mozilla/toolkit/xre/nsAppRunner.cpp:4408
#8  0x0000000000405a19 in do_main (argc=argc@entry=4, argv=argv@entry=0x7fffffffdbf8, xreDirectory=0x7ffff7d52780)
    at /mozilla/builds/nightly/mozilla/browser/app/nsBrowserApp.cpp:282
#9  0x0000000000405b48 in main (argc=4, argv=0x7fffffffdbf8) at /mozilla/builds/nightly/mozilla/browser/app/nsBrowserApp.cpp:643

If you add to /tmp/testprofile/user.js:

user_pref("browser.newtabpage.enabled", false);
user_pref("browser.newtabpage.directory.source", "about:blank");

the crash goes away.

I bisected this down to

The first bad revision is:
changeset:   201374:d76f7a57af61
user:        Ed Lee <edilee@mozilla.com>
date:        Wed Jul 23 14:33:13 2014 -0700
summary:     Bug 1042876 - Update newtab endpoints to new v2/links [r=adw]
Depends on: 1071107

Andre, can you reproduce?

No longer blocks: 1042876
Keywords: testcase
Regressed by: 1042876

Mardak - can you advise on next steps here?

Flags: needinfo?(edilee)

The code added in bug 1042876 was removed in bug 1370930, so this bug should no longer happen.

Status: NEW → RESOLVED
Closed: 13 days ago
Depends on: 1370930
Flags: needinfo?(edilee)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.