Closed Bug 1069820 Opened 11 years ago Closed 11 years ago

[Contact] Improve Default Image for Contacts (When Image is Missing)

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Carol, Assigned: pivanov)

Details

Attachments

(2 files)

Visual improvement on default image.
Attached file _Export_Contact.zip
Hi Pavel, Since the default image is too subtle right now, I've tweak the image a bit. Could you help swipe these images and send me a patch? I would like to see if it looks good enough on device. I'll be on PTO next week, if there's anything urgent, Helen will help on this bug. Thanks! note: I change the names of these images. Because previously the file names are not correct. Default_Image_BW_revised@1 > Default_Image_Contact.png Default_Image_BW_revised@1.5.png > Default_Image_Contact@1.5x.png Default_Image_BW_revised@2 > Default_Image_Contact@2x.png Default_Image_BW_revised@2.5 > Default_Image_Contact@2.5x.png Default_Image_Contact@2.25x.png
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master
Attachment #8492067 - Flags: ui-review?(chuang)
Flags: needinfo?(pivanov)
Comment on attachment 8492067 [details] [review] patch for Gaia/master It looks good to me!Thanks, Pavel!
Attachment #8492067 - Flags: ui-review?(chuang) → ui-review+
Attachment #8492067 - Flags: review?(francisco)
Comment on attachment 8492067 [details] [review] patch for Gaia/master LGTM, I think images already went through the compressing tool isnt? Thanks!
Attachment #8492067 - Flags: review?(francisco) → review+
Yep, they are already compressed :) Thanks :) Landed to master: https://github.com/mozilla-b2g/gaia/commit/01fcc1b44282a148451de6f7a8b302698c9efa9f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: nobody → pivanov
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: